Skip to content
This repository has been archived by the owner on Sep 20, 2023. It is now read-only.

Can’t search forks #2240

Closed
mvrozanti opened this issue Oct 7, 2018 · 20 comments
Closed

Can’t search forks #2240

mvrozanti opened this issue Oct 7, 2018 · 20 comments
Assignees
Labels
🐛 bug Unintended behaviour within the app ❔ question Question pending discussion or card yet to be correctly triaged

Comments

@mvrozanti
Copy link

mvrozanti commented Oct 7, 2018

And also I cannot some find my own repos.

Bug Report Dump (Auto-generated)
Version 1.22.0 (1534395229)
Device: iPhone 5s (iOS 11.4.1)
TestFlight: false
@Huddie
Copy link
Collaborator

Huddie commented Oct 8, 2018

@mvrozanti try searching mvrozanti/ (with the slash)

Sent with GitHawk

@mvrozanti
Copy link
Author

mvrozanti commented Oct 8, 2018

I did

Sent with GitHawk

@Huddie
Copy link
Collaborator

Huddie commented Oct 8, 2018

Without the st. Just mvrozanti/. I searched and got a lot of results . If your searching for a specific repo you’ll have to write it out completely.

Sent with GitHawk

@rnystrom rnystrom added the ❔ question Question pending discussion or card yet to be correctly triaged label Oct 8, 2018
@mvrozanti
Copy link
Author

mvrozanti commented Oct 8, 2018

I also tried searching for mvrozanti/ and while it did return many results, st, for instance did not show up.

It is a fork though. Does it not count as a repository belonging to the user who forked it?

@rnystrom
Copy link
Member

rnystrom commented Oct 8, 2018

@mvrozanti ya that should show up like anything else. Is it a private repo?

Sent with GitHawk

@mvrozanti
Copy link
Author

It is not.

@Huddie
Copy link
Collaborator

Huddie commented Oct 8, 2018

Neither is “dotty” for you @mvrozanti and I can’t see Huddie/GitHawk which I forked.
@rnystrom forks seem to be missing

Sent with GitHawk

@rnystrom
Copy link
Member

rnystrom commented Oct 8, 2018

Could be something with the search API or query that doesn't show fork results? That would be really strange...

@rnystrom rnystrom added the 🐛 bug Unintended behaviour within the app label Oct 8, 2018
@mvrozanti
Copy link
Author

mvrozanti commented Oct 8, 2018

Actually, some "self-owned" (not fork) repos are missing as well. Example: rastreamento-correios

@mvrozanti
Copy link
Author

Maybe it's my iOS version? Pardon my ignorance it's an old phone.

@Huddie
Copy link
Collaborator

Huddie commented Oct 9, 2018

I’m on iOS 12 and missing. Also doesn’t seem like that would be it

Sent with GitHawk

@rizwankce
Copy link
Collaborator

Looks like GitHub search will ignore fork repos by default. If we want to see the forked repos we have to specify that in search query like fork:true or we can even search only for forked repos by fork:only.

Checkout more on Searching for Repositories

I also fired up GraphQl Explorer to check and was able to get forked repos as like mentioned in docs.

query {
  search(query: "fork:true rizwankce/", type: REPOSITORY, first: 100) {
    repositoryCount
    edges {
      node {
        ... on Repository {
          name
        }
      }
    }
  }
}

@mvrozanti
Copy link
Author

mvrozanti commented Oct 9, 2018

That still wouldn’t explain non-forks not appearing as well though

Sent with GitHawk

@rizwankce
Copy link
Collaborator

@mvrozanti I was able to get that as well in search. GitHawk Upload by rizwankce

We can compare the search with github search and cross verify it.

Sent with GitHawk

@rizwankce
Copy link
Collaborator

I was able to get my forked repo just by entering Rizwankce/ fork:true so there is no difference between Github search and Githawk. But it's tricky to remember all search keywords.

Sent with GitHawk

@mvrozanti
Copy link
Author

mvrozanti commented Oct 9, 2018

@rizwankce ok rastreamento-correios is actually there, my bad; I thought I didn’t see it

Adding fork:true worked

Sent with GitHawk

@Huddie
Copy link
Collaborator

Huddie commented Oct 9, 2018

But this should be either added by default or we need a filter option. Users shouldn’t have to know to add /fork:true.

Sent with GitHawk

@mvrozanti
Copy link
Author

mvrozanti commented Oct 9, 2018

Maybe only disable or unfilter if they want? Should this be a setting?

Sent with GitHawk

@Huddie
Copy link
Collaborator

Huddie commented Oct 9, 2018

🤷‍♂️I feel people’s expectations are that forks appear

Sent with GitHawk

@rnystrom
Copy link
Member

rnystrom commented Oct 9, 2018

Let’s default to include forks

Sent with GitHawk

@mvrozanti mvrozanti changed the title Can’t search by username/repo Can’t search forks Oct 9, 2018
@Huddie Huddie self-assigned this Dec 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🐛 bug Unintended behaviour within the app ❔ question Question pending discussion or card yet to be correctly triaged
Projects
None yet
Development

No branches or pull requests

4 participants