Clarity on repo action sheets

[Huddie]

This is more a question but I guess it also may be a re-wording request.

Once inside an issue you have click the titlebar to get an action sheet that says @GitHawkApp and then GitHawk. @GitHawkApp will take me to the GitHawkApp homescreen in webview. If this is just a link to the Organizations page maybe a rewording is in order. @organization doesn't make me think I'm going to be redirected (Could be just me, I associate it with a message or something). The GitHawk option / Repo option opens the repo in app, this one makes a bit more sense but some clearer wording could still be added I feel. Even if it was. View Organization, View Repo or something like that.

[rnystrom]

The @ is supposed to denote a user/org. The thing I like is that the words are connected to the button you just tapped.

Adding “View” before each word wouldn’t hurt tho!

_{Sent with GitHawk}

[Huddie]

Ya view @GitHawkApp could clear it up a bit

_{Sent with GitHawk}

[BasThomas]

I feel like the @ and no @ are already tricky sometimes, especially with repositories like Moya/Moya. Anything that can make it more clear is 👍

[Huddie]

Maybe an icon that represents an organization and one that rep. A repo?

Along with the view @. And view
_{Sent with GitHawk}

[BasThomas]

Wait yeah we could add images with https://github.com/BasThomas/ImageAlertAction :)

[Huddie]

Boo ya!

_{Sent with GitHawk}

[Huddie]

Organization Icon: https://octicons.github.com/icon/organization/
Repo Icon: https://octicons.github.com/icon/repo/

[Huddie]

@BasThomas That was easy. Great pod!
So thoughts?

_{Sent with GitHawk}

[rnystrom]

Ehhhj it’s overkill IMO. Adding “View” makes it pretty clear.

I’d actually rather use ContextMenu for everything.

_{Sent with GitHawk}

[Huddie]

I think the view @GitHawkApp is a bit cluttered but otherwise I felt it was clear. You could probably go with either icons and not “view” or just view.

_{Sent with GitHawk}

[BasThomas]

I think it might also be the outlined image (for repo) vs the filled image for organization.

I agree with Ryan that consistency with ContextMenu would be really nice though :)

[Huddie]

Ya I think I rather both by outlined. Context menu would probably look nice as well. The feeling I get with context menu is that it's been used to "act" in the app. Assign labels, milestones..etc. Hopefully change the current branch (#1582). I guess since all it's doing is redirecting, context menu may be unnecessary.

[BasThomas]

Hm, good point. I feel like it could indeed be a bit too big of a context switch (ugh, no pun intended). I guess we can play with it and revert to what we have / this if the context menu doesn't work out.

In general I think both are a step in the right direction — I still get confused between @ and non-@, and any help disambiguating the two is greatly appreciated.

[BasThomas]

Something else we should keep in mind are the icons. A repo can also have an owner instead of an organization, and it would be nice to be able to have separate icons to indicate that.

[Huddie]

Agree

_{Sent with GitHawk}

[Huddie]

@rnystrom @BasThomas So whats the conclusion on this one? Context menu or UIAlertController? Icons/No Icons (If yes, outlined/filled) ? View/No View?

Aside: If we could add grey description text underneath the text we could get rid of the word view and clear things up a bit in the process.

[BasThomas]

After some more thought I'm leaning towards the UIAlertController with icons. If Ryan still prefers the ContextMenu, it would be nice to compare them!

[Huddie]

@rnystrom Context menu or UIAlertController

[BasThomas]

Closing as #2135 was merged

_{Sent with GitHawk}