Skip to content
This repository has been archived by the owner on Sep 20, 2023. It is now read-only.

 Watch Support #190

Closed
Sherlouk opened this issue Jul 27, 2017 · 24 comments
Closed

 Watch Support #190

Sherlouk opened this issue Jul 27, 2017 · 24 comments
Assignees
Labels
🆕 feature request A feature being requested to be added, not yet approved

Comments

@Sherlouk
Copy link
Member

Genuinely think this is the sort of app that I would love to have on an Apple Watch with the ability to quickly see notifications

@rnystrom
Copy link
Member

I love it. LONG way off, but would be super cool for a basic activity overview.

@BasThomas BasThomas mentioned this issue Sep 23, 2017
@rnystrom
Copy link
Member

Reviving, anything cool we could do here? Tbh I don't use any watch apps, just the complications. Maybe we could do something there?

@Sherlouk
Copy link
Member Author

Gonna join the gang next month when I get my series 3 😃

I think the main thing I'd like to see at a glance is how many unread notifications I have.

Obviously we could go insane and make it so you can actually see messages and use canned responses (different card) to reply - Much like how I see iMessages dealing with it

@BasThomas
Copy link
Collaborator

Just like @rnystrom, I am not using any 3rd party apps on the Watch. I think a complication would make sense as a first step.

Also curious how the Series 3 will perform; that might make it more interesting to look into building an app too. Think it should focus on something (eg. replying with saved replies) without trying to recreate a lot of the main app’s features.

@rnystrom
Copy link
Member

Btw, I'm basically open to anything here. If someone wants to hack at it I'll probably accept anything. I don't think I'll spend any time on this, but could be a neat side-kick. The today and home screen widgets are probably a lot more impactful.

@rnystrom
Copy link
Member

So this might actually help w/ App Store ranking. Might be worth hacking together something stupid simple just to have it...

@Sherlouk
Copy link
Member Author

Fun Fact: My Apple Watch went to dispatched today 😄 24th Oct and I'll be all over watch development!

The more Apple things you support the more they feature you, had first hand experience of that

@BasThomas
Copy link
Collaborator

tvOS?!

@Sherlouk
Copy link
Member Author

I don't watch TV often, but when I do, it's to check my GitHub notifications 😂

@Sherlouk
Copy link
Member Author

So what were people actually thinking of having for Apple Watch support?

A complication that just says how many unread notifications you have?

@BasThomas
Copy link
Collaborator

I would probably not use more than a complication to be honest.

@Sherlouk
Copy link
Member Author

As a starting point it'll give us enough structure to at least get notification information to the watch, as well as background polling to get information

It's definitely a start!

@Sherlouk
Copy link
Member Author

😁 I love it when things arrive early 😁😁

@BasThomas
Copy link
Collaborator

BasThomas commented Oct 19, 2017

No pic no proof 😉 Enjoy the watch!

Sent with GitHawk

@Sherlouk
Copy link
Member Author

Sherlouk commented Oct 20, 2017

image

🤷‍♂️ 👀

(dont get any hopes up)

@rnystrom
Copy link
Member

Oh shiiiiiitt! Those rings are pretty dope. Honestly that alone is worth shipping. Are there any rules around shipping only a complication? Does there have to be an app too?

Sent with GitHawk

@Sherlouk
Copy link
Member Author

So yeah I was just messing with how we can display the information. There's about 7 different display modes ("families") we can support (this is just the small modular one).

You have to have an app if you ship a complication (it opens automatically when you tap on the item). We could just have a screen which is like "Open App" or something (and deeplinks to the notifications page).

That right there is using fixed data, need to follow RayWenderlich's tutorial on watch connectivity to get notification info across.

I was hoping we could customise exactly how complications look, but from what I can tell you have to use one of about 8 different templates (image, text, combination of the two in different formats). The above is a bit of a trick, using CoreGraphics to take the outer bit of the app icon and then draw the text overlay (notification count). Text size is dynamic, and centered. (Get's smaller with bigger numbers!)

Unfortunately though we can't have different colours for the ring vs text (would've been amazing if we could!)

Using a different template we could just put the logo above the number? (That way we could have two colours). Or do we like this design? Really just playing around to see what's possible! Obviously when it's in the app we have a lot more creative control! -- I'd quite like this complication though, but again (as I've complained about before) counting how many people mention me rather than any notification! 😅 - Could be an option though!

@rnystrom
Copy link
Member

For sharing code, we probably want to look into migrating the networking + model stuff into a shareable framework to do this "right".

Also move authentication/tokens into app group containers 😬

@Sherlouk
Copy link
Member Author

Would also need the minimal persistency stuff in there for notifications as well so the number is actually correct. I'd say this is pretty dependent on #620 as well

@rnystrom rnystrom added 🆕 feature request A feature being requested to be added, not yet approved high and removed wishlist labels Apr 25, 2018
@rnystrom rnystrom self-assigned this Apr 25, 2018
@rnystrom
Copy link
Member

Claiming this to experiment w/ App Store ranking in the next release. Here's the app that I have in mind:

  • Open to list of notifications grouped by repo
    • Show repo name, number of notifications for repo, and button to mark them read (check mark)
    • Should show notification type (issue, PR, etc)
    • stretch: Get notification status. Requires breaking out V3+gql hack into shared lib.
  • Tapping cell shows list of all that repo's notifications w/ button to mark read
    • Long press on notification to show option to unsubscribe
  • Handle not-logged in state w/ a view saying you need to sign into GitHub via GitHawk app

@rnystrom
Copy link
Member

Have a local branch w/ extension + cocoapods refactor setup and building. Just a matter of slapping it together. Very curious how/if this impacts App Store ranking!

@BasThomas
Copy link
Collaborator

Closing this; any idea if this had any effect on ranking?

@rnystrom
Copy link
Member

rnystrom commented Jun 3, 2018

@BasThomas nothin 😭

Sent with GitHawk

@BasThomas
Copy link
Collaborator

😔

Sent with GitHawk

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🆕 feature request A feature being requested to be added, not yet approved
Projects
None yet
Development

No branches or pull requests

3 participants