Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Tests of GET API #82

Open
Manvityagi opened this issue Apr 28, 2021 · 11 comments · May be fixed by #97
Open

Update Tests of GET API #82

Manvityagi opened this issue Apr 28, 2021 · 11 comments · May be fixed by #97
Labels
GSSOC21 for GSSoC participants LEVEL2

Comments

@Manvityagi
Copy link
Member

GET API Tests are not updated for the pagination feature,
All the tests in controllers, managers, services shall be updated as per the latest version of GET API.

@github-actions github-actions bot added the GSSOC21 for GSSoC participants label Apr 28, 2021
@Sukriti-sood
Copy link
Contributor

Sukriti-sood commented Apr 29, 2021

I wan to work on this

@jnv27
Copy link
Contributor

jnv27 commented Apr 29, 2021

Hey @Manvityagi I would like to work on this issue and I've sent PR for my previous issue as well you can check and merge it.

@Kashish0423
Copy link
Contributor

Hello @Manvityagi mam , i just got my previous issue merged , can I take this issue ?

@Manvityagi
Copy link
Member Author

Sorry for the delay guys,
As per FCFS, @Sukriti-sood assigned to you

@Manvityagi
Copy link
Member Author

@Sukriti-sood Please update the tests asap, as the build is currently failing and that is probably because of the same issue.

@Sukriti-sood
Copy link
Contributor

@Sukriti-sood Please update the tests asap, as the build is currently failing and that is probably because of the same issue.

Ook

@Sukriti-sood
Copy link
Contributor

Sukriti-sood commented May 2, 2021

@Manvityagi I am unable to resolve following error:-
Screenshot from 2021-05-02 17-54-23

If image not uploaded due to any issue:-
OpportunityManager getOpportunities should retrieve Opportunities with specific opportunityType: Error: Timeout of 2000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (/home/sukriti/Desktop/Opportunity-Calendar-Backend/tests/managers/opportunity-test.js) at listOnTimeout (internal/timers.js:554:17) at processTimers (internal/timers.js:497:7)

@Manvityagi
Copy link
Member Author

@Manvityagi I am unable to resolve following error:-
Screenshot from 2021-05-02 17-54-23

If image not uploaded due to any issue:-
OpportunityManager getOpportunities should retrieve Opportunities with specific opportunityType: Error: Timeout of 2000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (/home/sukriti/Desktop/Opportunity-Calendar-Backend/tests/managers/opportunity-test.js) at listOnTimeout (internal/timers.js:554:17) at processTimers (internal/timers.js:497:7)

Take the latest pull, this error is resolved now.

@Sukriti-sood Sukriti-sood linked a pull request May 3, 2021 that will close this issue
@ria-19
Copy link

ria-19 commented Aug 5, 2021

Is this still open? I would like to contribute to this project.

@Sukriti-sood Sukriti-sood removed their assignment Dec 15, 2021
@devTenshi
Copy link

can i get assigned to this task please? i am a GSSOC"23 participant

@jnv27
Copy link
Contributor

jnv27 commented May 22, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GSSOC21 for GSSoC participants LEVEL2
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants