Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug in pagination helper code #107

Open
Sukriti-sood opened this issue May 24, 2021 · 0 comments · May be fixed by #97
Open

Bug in pagination helper code #107

Sukriti-sood opened this issue May 24, 2021 · 0 comments · May be fixed by #97
Labels
GSSOC21 for GSSoC participants

Comments

@Sukriti-sood
Copy link
Contributor

Sukriti-sood commented May 24, 2021 •
edited

In PAgination Helper Code :-

  • There are some unnecessary variable used
  • Logic for total pages is also wrong
    if (numDocs >= limit) { totalPages = Math.floor(numDocs / limit) + (numDocs % limit); }
  • It was not filtering Opportunities On the Basis of Opportunity-Type.

This issue has been resolve in PR of GET API TEST #97
@github-actions github-actions bot added the GSSOC21 for GSSoC participants label May 24, 2021
@Sukriti-sood Sukriti-sood reopened this May 24, 2021
@Sukriti-sood Sukriti-sood linked a pull request May 24, 2021 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
GSSOC21 for GSSoC participants
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Test for Get Api Updated
1 participant
@Sukriti-sood