Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark theme ~~Suggestion to remove GA~~ #1

Closed
leaty opened this issue Nov 22, 2021 · 4 comments · Fixed by #2
Closed

Dark theme ~~Suggestion to remove GA~~ #1

leaty opened this issue Nov 22, 2021 · 4 comments · Fixed by #2
Assignees
Labels
enhancement New feature or request

Comments

@leaty
Copy link

leaty commented Nov 22, 2021

As the title says. Unfortunately I also made a really quick and dirty dark theme for my eyes at the same time and didn't bother with branches. But it's a tiny change, see here leaty@a6fb372

I'll make a PR if you agree.

@leaty leaty added the bug Something isn't working label Nov 22, 2021
@GeorgeV220
Copy link
Owner

Hello,
Thank you for the suggestion. If you want open a pull request. Now about the dark theme, if you made it work with a button it would be awesome

@leaty
Copy link
Author

leaty commented Nov 22, 2021

PR coming right up.

For the dark theme, it's definitely a no currently. It was quick and dirty after all, it's also a bit of a mess where all the theming options are in champ-r. Maybe some other time I could try, or just yoink it from here leaty@7b6b265 🙂

@leaty leaty mentioned this issue Nov 22, 2021
@leaty
Copy link
Author

leaty commented Nov 22, 2021

Here's a darker theme supposed to mimic the client better, but as you can see it's far from perfect. I don't know where to customize the buttons except switching between the defaults "Dark" and "Light" provided by base-ui.

screen 2021-11-22 18 42 43

@GeorgeV220
Copy link
Owner

I will probably implement it with a switch for light and dark theme. Thank you for your contribution to this project!!

@GeorgeV220 GeorgeV220 reopened this Nov 22, 2021
@GeorgeV220 GeorgeV220 added enhancement New feature or request and removed bug Something isn't working labels Nov 22, 2021
@GeorgeV220 GeorgeV220 self-assigned this Nov 22, 2021
@GeorgeV220 GeorgeV220 changed the title Suggestion to remove GA Dark theme ~~Suggestion to remove GA~~ Nov 22, 2021
@GeorgeV220 GeorgeV220 pinned this issue Nov 22, 2021
GeorgeV220 added a commit that referenced this issue Jun 27, 2022
GeorgeV220 added a commit that referenced this issue Jun 27, 2022
Closes (#1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants