Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Request]: Bundle all icons we use #934

Open
1 task done
GeopJr opened this issue May 4, 2024 · 0 comments · May be fixed by #939
Open
1 task done

[Request]: Bundle all icons we use #934

GeopJr opened this issue May 4, 2024 · 0 comments · May be fixed by #939
Labels
enhancement New feature or request

Comments

@GeopJr
Copy link
Owner

GeopJr commented May 4, 2024

Describe the request

The recent AIT discussion just further made me realize how useless it is to not bundle all icons.

Tuba uses the icon spec whenever possible, but it's so limited that it's impossible to use for everything. That leads to icon inconsistencies.

Here's what it looks like with adwaita:

image

Here's what it looks like with yaru:

image

You see how the different icon styles just look bad next to each other.

Someone on fedi tagged me some ages ago about an issue and I noticed how terrible their icon theme was with matching the spec as well:

image

See the 'Conversations' entry, the icon was supposed to be an envelope. The theme changed it into a circle, making it lose its meaning completely.

Ultimately, I don't think the icon spec will ever work, no matter how much you extend it. Here's some cases that will probably never make it in:

  • The boost button uses the 'media repeat' icon. If it wasn't bundled, themes would assume it's meant for audio players and might change the meaning it has in Tuba.

image

  • Tuba also uses 'mini' icons for the post kinds. These are not just 'icons but smaller size', they use the same pixel grid but are drawn smaller.

image

This just leads to a bad experience for everyone using custom icon themes

Implementation Details

@GeopJr GeopJr added the enhancement New feature or request label May 4, 2024
@GeopJr GeopJr linked a pull request May 5, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant