Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misskey API support #32

Open
ThatOneCalculator opened this issue Dec 13, 2022 · 20 comments · May be fixed by #357
Open

Misskey API support #32

ThatOneCalculator opened this issue Dec 13, 2022 · 20 comments · May be fixed by #357
Labels
calckey Calckey related issue

Comments

@ThatOneCalculator
Copy link

Having this act as more of a cross-fediverse client rather than specifically a Mastodon client would help differentiate it :)

@GeopJr
Copy link
Owner

GeopJr commented Jan 3, 2023

I really like Misskey/Calckey so I'm definitely interested in supporting them!

I gave it some tries since this issue opened but it's semi-blocked by #12 and #14. In the meantime if/when Calckey gets Mastodon API compat, similar to Pleroma or Akkoma, it should be supported by Tooth!

@McSinyx
Copy link

McSinyx commented Jan 3, 2023

Would (custom) emoji reactions be supported? This also affects Pleroma and Akkoma, and it requires a layout change.

@ThatOneCalculator
Copy link
Author

@GeopJr I don't think they'll ever get Masto API support to be honest, it'd moreso be you implementing the Mk API

@GeopJr
Copy link
Owner

GeopJr commented Jan 3, 2023

Would (custom) emoji reactions be supported? This also affects Pleroma and Akkoma, and it requires a layout change.

Opened another issue for it #44

@GeopJr I don't think they'll ever get Masto API support to be honest, it'd moreso be you implementing the Mk API

I mostly went by this comment: https://codeberg.org/calckey/calckey/issues/9256#issuecomment-731083 but since the issue is now closed I take it as not planned. (Either way, when I said "in the meantime" I meant until those 2 issues get fixed and full mk/ck API support gets added!)

@ThatOneCalculator
Copy link
Author

ThatOneCalculator commented Mar 23, 2023

@GeopJr we now support the Mastodon API! You can test it out on https://calckey.social

It works sort of, but there's an issue of no images loading, which appears to be unique to Tootle and Tuba.

image

@ThatOneCalculator ThatOneCalculator changed the title Calckey/Misskey API support Calckey support Mar 24, 2023
@GeopJr
Copy link
Owner

GeopJr commented Mar 24, 2023

I'm having trouble reproducing, could you send me your debugging information? (About > Troubleshooting > Debugging Information)

Also, could you give running from a terminal a try? There will be a lot of logs so keep an eye around Network.vala:50: GET: https://calckey.social/files/36d58ab7-6931-47f3-a5a5-e21889fe1ce7 for media urls

image

@GeopJr
Copy link
Owner

GeopJr commented Mar 24, 2023

On further debugging it, I found the following issues:

  • When selecting a profile it 401s (/api/v1/accounts/$id/statuses) Request "https://calckey.social/api/v1/accounts/9arjouq4ja/statuses?pinned=true" failed: 401 Unauthorized
  • Account header was null, probably related to the above

Selecting my own profile however, seems to use the Mastodon id instead https://calckey.social/api/v1/accounts/057099112122053114116103113105/statuses?only_media=false&exclude_replies=true&limit=20 and a http.cat header is available

@ThatOneCalculator
Copy link
Author

ThatOneCalculator commented Mar 24, 2023

Interesting, I'll investigate that.

Can you also make an account on https://stop.voring.me? calckey.social stores its files on disk, but stop.voring.me uses a CDN, and I get this error:

(dev.geopjr.Tuba:16293): Tuba-WARNING **: 12:01:58.253: ImageCache.vala:44: Failed to download image at "https://pool.jortage.com/voringme/misskey/thumbnail-0b704e35-8d0d-4976-9c32-c4e3d8457007.webp". Unrecognized image file format.

Debug info:

os: EndeavourOS (null)
prefix: /usr
flatpak: false
version: 0.1.0 (production)
gtk: 4.10.1 (4.10.1)
libadwaita: 1.3.1 (1.3.1)
libsoup: 2.74.3 (2.74.3)

@GeopJr
Copy link
Owner

GeopJr commented Mar 24, 2023

Still can't reproduce, my only speculation is that you are missing webp libraries, I think it's webp-pixbuf-loader, could you give it a try?

@ThatOneCalculator
Copy link
Author

Yep, that fixed it. That should probably be added as a dependency for the AUR.

@GeopJr
Copy link
Owner

GeopJr commented Mar 24, 2023

cc: @fabiscafe

(probably optional dependency?)

@ThatOneCalculator
Copy link
Author

One more bug: unicode emoji reactions show, but custom emoji reactions don't.

image

@GeopJr
Copy link
Owner

GeopJr commented Mar 24, 2023

Pleroma and Mastodon forks (that support reactions), provide the url for custom emojis:

{
      "count" : int,
      "me" : bool,
      "name" : string,
      "url" : string?
}

Calckey doesn't seem to do so:
https://stop.voring.me/api/v1/statuses/9cn6nnxz8g

{
      "count": 1,
      "me": false,
      "name": ":rage1@.:"
}

@fabiscafe
Copy link
Contributor

Still can't reproduce, my only speculation is that you are missing webp libraries, I think it's webp-pixbuf-loader, could you give it a try?

Update is available 🥳

Would you add a meson check for it as runtime dependency to the next version? Usually in situations where it is not a compile time dependency I'd add it as optional dependency, but since this is UX breaking it should be a hard dependency (and is on the PKGBUILD)

@GeopJr
Copy link
Owner

GeopJr commented Mar 24, 2023

Thanks!

I feel like you'll be asked to make it optional since technically it works without it, but if you are not until the next release, I'll add a meson check!

@fabiscafe
Copy link
Contributor

Thanks! Let's not tell anyone, so nobody will notice 😏

@GeopJr GeopJr added the calckey Calckey related issue label Apr 4, 2023
@VarLad
Copy link

VarLad commented Jun 12, 2023

@GeopJr So does Misskey work on Tuba yet? If not, any plans in the future?

@GeopJr
Copy link
Owner

GeopJr commented Jun 13, 2023

As long as this issue is open, it's safe to assume that it's not. Priority for mk api support is low for me at the moment but I'm happy to review any PRs for it!

edit: Calckey's mastodon api compat should work however

@ThatOneCalculator
Copy link
Author

The compatibility layer is very barebones, so proper API support in the future would be much appreciated.

@GeopJr
Copy link
Owner

GeopJr commented Jun 19, 2023

Started initial support on this branch: https://github.com/GeopJr/Tuba/tree/experiment/wip/feat/mk-api-support

It's very far from being usable, I've only completed the login flow and basic compat for some objects. Priority is still low. The plan is to first get the tuba 100% usable for Misskey (replacing Mastodon support) and then split it into its own thing (edit: as in include it as an addon to tuba - not a separate app) so if anyone is planning on testing/contributing it might mess up your saved accounts (and you might have to remove them manually from Passwords & Keys (seahorse)).

@GeopJr GeopJr linked a pull request Jul 6, 2023 that will close this issue
40 tasks
@GeopJr GeopJr changed the title Calckey support Misskey API support Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
calckey Calckey related issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants