Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Request]: Full-width media #180

Open
1 of 4 tasks
bertob opened this issue Apr 10, 2023 · 9 comments · May be fixed by #181
Open
1 of 4 tasks

[Request]: Full-width media #180

bertob opened this issue Apr 10, 2023 · 9 comments · May be fixed by #181
Labels
enhancement New feature or request

Comments

@bertob
Copy link
Contributor

bertob commented Apr 10, 2023

Describe the request

It's a bit odd that images only use half the width when there's just one, especially at narrower widths. Could we special case the single image case and use the full wdith?

image

Implementation Details

  • This should be an option in settings.
  • This should be only available to some fediverse backends. (Include which ones on the above field).
  • This is client-only (and shouldn't sync with the instance).
  • This follows the GNOME HIG.
@bertob bertob added the enhancement New feature or request label Apr 10, 2023
@GeopJr
Copy link
Owner

GeopJr commented Apr 10, 2023

like so?

image

we can also increase the height:
image

@bertob
Copy link
Contributor Author

bertob commented Apr 10, 2023

Yeah, increasing the height sounds good, so the aspect ratio doesn't get too wide. Could go even taller than what you have there, IMO. Elk doesn't seem to limit the height at all, which seems like a bit much too me. I'd try 4:3 or square as the max aspect ratio.

image

@GeopJr
Copy link
Owner

GeopJr commented Apr 10, 2023

4:3
Screenshot from 2023-04-11 01-58-55

square
Screenshot from 2023-04-11 01-58-21

@bertob
Copy link
Contributor Author

bertob commented Apr 11, 2023

I think square could work, but I would not force an aspect ratio for landscape images, and just show the whole image instead, i.e. images taller than 1:1 would be scaled up and clipped, while images wider than 1:1 would be scaled down and shown without cropping (maybe up to a minimum height of like 100px or so, after which they should probably be scaled up and cropped to keep them a reasonable aspect ratio).

@bertob
Copy link
Contributor Author

bertob commented Jul 23, 2023

This looks fixed to me on the latest main:

image

@bertob bertob closed this as completed Jul 23, 2023
@GeopJr
Copy link
Owner

GeopJr commented Jul 23, 2023

It just makes the attachment bigger, it does not follow the previous comment #180 (comment) so I left it open (unless it's good enough as is?)

@GeopJr GeopJr reopened this Jul 23, 2023
@bertob
Copy link
Contributor Author

bertob commented Jul 23, 2023

Mmmh, not sure I follow what it doesn't do to be honest :D

@GeopJr
Copy link
Owner

GeopJr commented Jul 24, 2023

Currently the attachment is either cover fitted (the default) or contain fitted (if enabled in settings (letterbox))

images taller than 1:1 would be scaled up and clipped

✔️ cover takes care of it

while images wider than 1:1 would be scaled down and shown without cropping (maybe up to a minimum height of like 100px or so, after which they should probably be scaled up and cropped to keep them a reasonable aspect ratio).

❌ The following image

Screenshot from 2023-07-24 02-54-47

will look like this

image

while you probably are looking for something like this

image

@bertob
Copy link
Contributor Author

bertob commented Jul 24, 2023

Ah, gotcha! Thanks for explaining, and yes that is what I had in mind :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants