Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bit/Bool syntax in statplots.jl : "|" is not a unary operator #1223

Open
standarddeviant opened this issue Jul 24, 2023 · 2 comments
Open

Bit/Bool syntax in statplots.jl : "|" is not a unary operator #1223

standarddeviant opened this issue Jul 24, 2023 · 2 comments

Comments

@standarddeviant
Copy link

There's a bit of syntax that uses the . operator combined with the boolean || operator here:
https://github.com/GenericMappingTools/GMT.jl/blob/master/src/statplots.jl#L385

This works on newer versions of Julia, but not older versions. For example, that kind of syntax produces an error on the current LTS release of Julia, 1.6.7.

I think this code:
ind = ind_l .|| ind_h

Could be replaced with this code to in order to work in more places:
ind = collect(ind_l .| ind_h)

For a quick example, try running this test script with different Julia versions:

a=[true, false, true];
print("a = $a, typeof(a) = $(typeof(a))");

b = [true, false, false];
print("b = $b, typeof(b) = $(typeof(b))");

c = a .| b;
print("c = $c, typeof(c) = $(typeof(c))");

d = collect(a .| b);
print("d = $d, typeof(d) = $(typeof(d))");

e = a .|| b;
print("e = $e, typeof(e) = $(typeof(e))");
@joa-quim
Copy link
Member

Sorry, not a good time for changes (will leave in vacations). But other things (don't remember which by memory) will not work in 1.6 as well.

@joa-quim
Copy link
Member

joa-quim commented Nov 7, 2023

Sorry, forgot this but I'm afraid there is nothing we can do here. GMT.jl does not build with Julia1.6 anymore since the introduction of the GMT_jll artifact because a chain of dependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants