Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] Change the type of the object in InitGameEvent. #43

Open
HuaYuan-Tseng opened this issue May 1, 2024 · 3 comments · May be fixed by #44
Open

[Enhancement] Change the type of the object in InitGameEvent. #43

HuaYuan-Tseng opened this issue May 1, 2024 · 3 comments · May be fixed by #44
Assignees
@HuaYuan-Tseng
Labels
bug Something isn't working enhancement New feature or request

Comments

@HuaYuan-Tseng
Copy link
Contributor

If use pointer to pass the information back to front-end, perhaps will segmentation fault when call a non-exist game_id (#41 ).

To separate the concerns of InitGameEvent and InitGamePresenter, and also for the thread-safe, we will modify the pointer type to object type (maybe std::string etc.) in InitGameEvent.
@HuaYuan-Tseng HuaYuan-Tseng added bug Something isn't working enhancement New feature or request labels May 1, 2024
@HuaYuan-Tseng HuaYuan-Tseng self-assigned this May 1, 2024
HuaYuan-Tseng added a commit that referenced this issue May 15, 2024
@HuaYuan-Tseng
[Modify] Change the type of members in InitGameEvent. (#43)
7c76462 
- Add class: 'EventPlayer'.
@HuaYuan-Tseng
Copy link
Contributor Author

Now it can return the error status code normally and would not crash.

SCR-20240515-ttwu

@angtsusiong
Copy link
Contributor

#42 Stil Segmentation fault
image

@angtsusiong
Copy link
Contributor

angtsusiong commented May 17, 2024 •
edited

#42 Stil Segmentation fault image

image
image

@angtsusiong angtsusiong linked a pull request May 17, 2024 that will close this issue
42 check pointer not null #44
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@HuaYuan-Tseng HuaYuan-Tseng

Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

42 check pointer not null Game-as-a-Service/Machi-Koro-Cpp
2 participants
@angtsusiong @HuaYuan-Tseng