fix: Add IconV2 with new svg settings and revert old Icons changed by PR #384 #387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 5, 2024 20:45
…at least one keyboard listener
physicsSorcererKing
force-pushed
the
hotfix/some-icon-disappeared
branch
from
7492b0f
to
05d8e60
Compare
|
|
✅ Knip Scan Result for 9d1aaa8 Unused files (9)
Unused dependencies (2)
Unused devDependencies (5)
Unused exported types (2)
Unused exported types in namespaces (1)
Configuration issues (1)
|
|
🤖 Lighthouse Scan Result for 9d1aaa8 /rooms
/rooms/abc
/login
|
physicsSorcererKing
changed the title
physicsSorcererKing
requested review from
JohnsonMao
and removed request for
ricksu978
physicsSorcererKing
changed the title
JohnsonMao
approved these changes
May 25, 2024
|
|
||
| return ( | ||
| <> | ||
| <p className="absolute top-[-1.25rem] right-0 text-white/90"> |
There was a problem hiding this comment.
這裡的 className 幫我調整成 absolute top-0 right-4 text-zinc-950
讓 storybook 的白畫面可以看的到字
| label="搜尋" | ||
| value={value} | ||
| onChange={setValue} | ||
| labelClassName="mr-3 leading-normal" |
There was a problem hiding this comment.
labelClassName 也幫我改成 mr-3 leading-normal text-zinc-950
讓字顯示出來
| onClick={handleClick(iconName)} | ||
| > | ||
| <IconV2 name={iconName} className="w-full h-full" /> | ||
| <p className="text-center text-white/90 whitespace-nowrap"> |
There was a problem hiding this comment.
這裡的 className 幫我改成 text-center text-zinc-950 whitespace-nowrap
讓字顯示出來
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why need this change? / Root cause:
Changes made:
Test Scope / Change impact:
Issue