You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
recvuntil() uses drop kwarg, while recvline() and recvlines() use keepends. keepends is a logical negation of drop, while both serve the same purpose. I find this unnecessarily confusing.
I would like to propose using the same kwarg for the purpose of those functions.
It's a matter of discussion whether drop or keepends or maybe a new different keyword is better.
The new keyword can be added while preserving the old behaviour.
The text was updated successfully, but these errors were encountered:
I agree it's better to have them consistent. We could just support both drop and keepends in both functions too :D
I'm in favor of drop since keepends doesn't make much sense for recvuntil.
In my opinion, this one is a bit tricky because changing/removing kwargs ruins backwards compatibility for everyone using the keepends kwarg. The keepends kwarg is also used much more than the drop kwarg, so I'm not sure if this is something that a lot of users would expect. Supporting a both could also be weird/conflicting if a user sets both kwargs to the same values (even though they're supposed to be opposites). If we do want to remove the keepends kwarg, we could start off by issuing a Deprecation warning in the code and then implementing the changes in a future release, and raising an exception if keepends is used. Please let me know your thoughts!
recvuntil()
usesdrop
kwarg, whilerecvline()
andrecvlines()
usekeepends
.keepends
is a logical negation ofdrop
, while both serve the same purpose. I find this unnecessarily confusing.I would like to propose using the same kwarg for the purpose of those functions.
It's a matter of discussion whether
drop
orkeepends
or maybe a new different keyword is better.The new keyword can be added while preserving the old behaviour.
The text was updated successfully, but these errors were encountered: