Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Zygote rrule(typeof(apply),...) performance drop #277

Open
GTorlai opened this issue Apr 7, 2022 · 2 comments
Open

Zygote rrule(typeof(apply),...) performance drop #277

GTorlai opened this issue Apr 7, 2022 · 2 comments
Labels
-> PRIORITY <- performance Performance-related issues

Comments

@GTorlai
Copy link
Owner

GTorlai commented Apr 7, 2022

Looks like the time-to-solution to obtain gradients from TEBD simulation of dynamics (i.e. OCC) have substantial overhead compare to simple evaluation of the function.
@GTorlai GTorlai added performance Performance-related issues -> PRIORITY <- labels Apr 7, 2022
@mtfishman
Copy link
Collaborator

Could you share a benchmark code and some timings? What's the ratio of the time to compute the gradient to the time of just computing the function?

@GTorlai
Copy link
Owner Author

GTorlai commented Apr 7, 2022

This performance drop has been reported by a user. I will work to produce a minimal example. I just opened this not to forget.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
-> PRIORITY <- performance Performance-related issues
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mtfishman @GTorlai