Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modal Delivery Option Accessibility Best Practice #685

Open
kah8150 opened this issue Oct 7, 2021 · 2 comments
Open

Modal Delivery Option Accessibility Best Practice #685

kah8150 opened this issue Oct 7, 2021 · 2 comments

Comments

@kah8150
Copy link

kah8150 commented Oct 7, 2021

It appears the modal delivery option injects the touchpoints button at the end of the element. When running the Axe DevTools plugin (axe-core 4.3.3) it provides an accessibility best practice recommendation to make sure all content is contained by an HTML landmark (details here).

Would it be possible to provide an option when using the modal delivery option to allow implementers to provide a selector for the html element to inject the touchpoints button into?

Thanks!

cc @lauraGgit
@ryanwoldatwork
Copy link
Collaborator

Hi @kah8150 - thanks!

Seems possible. Can you put 30 minutes on my calendar next week to discuss?

@ryanwoldatwork
Copy link
Collaborator

ryanwoldatwork commented Oct 20, 2021 •
edited

We can add an element id in which to insert the button.
If the element id is blank, the button will be appended to <body> like it currently is.

Update:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kah8150 @ryanwoldatwork