Investigate and clean up any lingering database calls with the message sending code path

[ccostino]

After the discussion we had related to the message-ending code path, one of the things we'd like to do is investigate the message sending code path for any lingering database calls and whether they are truly necessary or if they can also be removed. Some work was previously done to remove PII from the database, which shifted a part of the processing to leveraging Redis for the notification queuing.

If we do need to keep the calls, we'd like to make sure they're functioning as they should and clean things up wherever necessary.

Implementation Sketch and Acceptance Criteria

• Check for any lingering database calls in the message sending code path
  • If we can remove them, let's do that
  • If we need to keep them look for any opportunities for clean up or improvement.
• Take a final look and review @terrazoon's PR that removes that last bits of personalization from the database: remove personalisation from db #783

Security Considerations

• We want to make sure we're not storing any PII in the database.
• We also want to make sure that we're handling PII carefully and securely during the message sending process.

[ccostino]

Noting here that I've given a final review of #783 for the removal of personalization from the DB!

[xlorepdarkhelm]

Not really seeing anything needing to be done here. Which is good, I think.

[ccostino]

Awesome, thanks, @xlorepdarkhelm! When you feel you've reviewed all the potential touch points or if there's nothing else to really dig into at this point, then I think we're ready to close this as done. 🙂