Switch to the new withnav_template #1480
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Once ticket- Switch to the new base.html template gets merged, these test errors will also clear. It's currently throwing an error because "base.html" template is missing from this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I replaced child templates that previously extended settings_template and org_template with the new withnav_template.html template. The new withnav_template is a combination of the old withnav, settings, and org templates.
Settings_template, settings_nav, org_template, org_nav...etc are all moved under "old" folder since we no longer need them. I moved them under "old" in case we need to reference them. When we are ready, we can delete them.