Switch to the new base.html template #1470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccostino
approved these changes
May 17, 2024
There was a problem hiding this comment.
Thank you, @heyitsmebev, it's awesome to see this all come together! 🎉
ccostino
deleted the
1463-convert-basehtml-template-to-become-the-new-main-template
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Task: Switched out the main_template, admin_template, content_template and withoutnav_template to the base.html
Security Considerations
There could be some minor security considerations with whether a user is logged in or not. User should not be able to see things such as navigation bar or banner if they are not logged in. I made some changes to the header to fix this