Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor integration/unit tests #4751

Closed
1 task
rshewitt opened this issue May 14, 2024 · 0 comments
Closed
1 task

refactor integration/unit tests #4751

rshewitt opened this issue May 14, 2024 · 0 comments
Assignees
Labels
H2.0/General General Harvesting 2.0 Issues

Comments

@rshewitt
Copy link
Contributor

User Story

In order to better organize the harvesting logic app tests datagov wants to isolate the integration tests which exist as unit tests.

Acceptance Criteria

[ACs should be clearly demoable/verifiable whenever possible. Try specifying them using BDD.]

  • GIVEN the harvesting logic app tests
    WHEN a reorganization of the unit and integration tests happens
    THEN integration tests will be separate from unit tests \

Background

  • this ticket really only involves the db tests. they should be moved to integration tests.
  • we currently only run unit tests in our action (source). we may want to consider including the integration tests because we have some control over them ( i.e. we setup the postgres instance via our compose file and have a cloud foundry instance to interact with )

Security Considerations (required)

[Any security concerns that might be implicated in the change. "None" is OK, just be explicit here!]

Sketch

  • move test_db.py from the unit test into the integration tests
  • include integration tests when running pytest
@rshewitt rshewitt added the H2.0/General General Harvesting 2.0 Issues label May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
H2.0/General General Harvesting 2.0 Issues
Projects
Status: 🗄 Closed
Development

No branches or pull requests

3 participants