Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[INTAKE]: Unique check on passthroguh name/id number #2505

Open
Tracked by #2511
, #3358
...
jadudm opened this issue Oct 16, 2023 · 2 comments · May be fixed by #3442
Open
Tracked by #2511
, #3358
...

[INTAKE]: Unique check on passthroguh name/id number #2505

jadudm opened this issue Oct 16, 2023 · 2 comments · May be fixed by #3442
Assignees
@sambodeme
Labels
eng

Comments

@jadudm
Copy link
Contributor

jadudm commented Oct 16, 2023

For all direct awards that are N, we need to check that the set of passthrough names and award IDs are unique. E.g.

is_direct? name id
N bob 1
N bob 2
N alice 1
N bob 2

is invalid.
@jadudm jadudm added the eng label Oct 16, 2023
@jadudm
Copy link
Contributor Author

jadudm commented Oct 16, 2023

The federal program name (as a source of dollars) may be an important part of this set.

That is, perhaps you should only have the passthrough name appear once per federal program name.

@sambodeme sambodeme mentioned this issue Oct 17, 2023
Open
@jadudm jadudm mentioned this issue Feb 7, 2024
Closed
@sambodeme sambodeme self-assigned this Feb 21, 2024
sambodeme added a commit that referenced this issue Feb 23, 2024
@sambodeme
#2505 Added logic to default missing passthrough id to N/A
bd1142c
sambodeme added a commit that referenced this issue Feb 23, 2024
@sambodeme
#2505 Added logic to check passthrough entity uniqueness
48ca848
sambodeme added a commit that referenced this issue Feb 23, 2024
@sambodeme
#2505 Bug fix
29416c3
sambodeme added a commit that referenced this issue Feb 23, 2024
@sambodeme
#2505 Missed to add this to my previous commits
b0756b8
sambodeme added a commit that referenced this issue Feb 23, 2024
@sambodeme
#2505 Adding test cases
5086a4d
sambodeme added a commit that referenced this issue Feb 23, 2024
@sambodeme
#2505 Code improvement
47cc536
@sambodeme sambodeme linked a pull request Feb 23, 2024 that will close this issue
2505 intake unique check on passthroguh nameid number #3442
Draft
14 tasks
@sambodeme sambodeme linked a pull request Feb 23, 2024 that will close this issue
Draft
14 tasks
@jadudm jadudm mentioned this issue Feb 26, 2024
Open
@danswick
Copy link
Contributor

danswick commented May 3, 2024

This is getting pretty stale. It looks like @sambodeme is waiting on feedback so I'm moving to "Blocked."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sambodeme sambodeme

Labels
eng
Projects
FAC
Status: Blocked
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

2505 intake unique check on passthroguh nameid number GSA-TTS/FAC
3 participants
@jadudm @danswick @sambodeme