Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ChangePoints kernel does not support active_dims #1195

Open
st-- opened this issue Jan 6, 2020 · 0 comments · May be fixed by #1671
Open

ChangePoints kernel does not support active_dims #1195

st-- opened this issue Jan 6, 2020 · 0 comments · May be fixed by #1671
Labels
bug good first issue If you want to become a GPflow contributor!
Projects

Comments

@st--
Copy link
Member

st-- commented Jan 6, 2020

ChangePoints kernel does not support active_dims, which means that it can only be used when the entire input is 1D, whereas it should be possible to have a changepoints kernel apply to any single dimension of the input.

ChangePoints should accept the active_dims keyword, and check that it is of length 1 only.
(Also, some error-handling in K() would be good; the tensorflow error that is produced at the moment isn't very helpful.)

Minimal example: https://stackoverflow.com/questions/59613675/gpflow-change-point-kernel-issue-with-multiple-dimensions

@st-- st-- added the bug label Jan 6, 2020
@st-- st-- added this to To do in Open bugs via automation Apr 9, 2020
@st-- st-- moved this from To do to Low priority in Open bugs May 7, 2020
@st-- st-- added the good first issue If you want to become a GPflow contributor! label Oct 2, 2020
@clwgg clwgg linked a pull request Apr 19, 2021 that will close this issue
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug good first issue If you want to become a GPflow contributor!
Projects
Open bugs
  
Low priority
Development

Successfully merging a pull request may close this issue.

1 participant