Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request - Highlighting call instruction with call address/instruction #26

Open
vivonk opened this issue Apr 17, 2018 · 5 comments

Comments

@vivonk
Copy link

vivonk commented Apr 17, 2018

As of now, when I write

UNPCK: ; my code goes here
CALL UNPCK

then UNPCK is not highlighted. If it will be highlighted then it will look like a high-level languages preference. If we can make something like this then it would be nice.
I can help to implement also 😊

@onkarshinde
Copy link
Contributor

Can you please confirm where exactly do you see the problem with highlighting? UNPCK: should already be highlighted.

@vivonk
Copy link
Author

vivonk commented Apr 23, 2018

My mean to say is when I JMP to somewhere then if it can verify that it's a valid JUMP so that compilation error will become less.

@onkarshinde
Copy link
Contributor

The syntax highlighting in gtksourceview (used by this application) just highlights the words based on character patterns.
There is no way to highlight an incorrect JMP or CALL because the editor does not know that it is invalid.

@onkarshinde
Copy link
Contributor

@vivonk Do you have any suggestions on how this can be implemented? Do you have a patch for this?

@vivonk
Copy link
Author

vivonk commented Aug 31, 2018

I would like to implement this feature if you could guide me through the codebase a little bit :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants