Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only works if Facebook is set to english, but doesn't check first #38

Open
nedt opened this issue Aug 8, 2018 · 1 comment
Open

Only works if Facebook is set to english, but doesn't check first #38

nedt opened this issue Aug 8, 2018 · 1 comment

Comments

@nedt
Copy link

nedt commented Aug 8, 2018

It took me some time to realize why no all suggestions were without mutual friends. Thought the parser had problems, when it only assumed a setting that not all might share.

Would be good to add to the instructions, that a specific language is expected (I'm now on english (US), don't know if the others would work). Would be even better if a check is made (i.e. headline is "People You May Know") and inform the user that the set language is not supported.

@davidschlachter
Copy link

This is specifically for showing the number of mutual friends. The actual text from Facebook is stored (e.g. "John Doe et 29 autres ami(e)s en commun" for fr-CA — visible by doing a data export), but parser.js uses English strings (e.g. "are mutual friends") to analyze this data. If somebody wants to build in multilingual support, parser.js is the place to add it. For myself I just changed by FB language to en-US.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants