Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IS updates #1

Open
zjin-lcf opened this issue Aug 30, 2021 · 9 comments
Open

IS updates #1

zjin-lcf opened this issue Aug 30, 2021 · 9 comments
Labels
bug Something isn't working

Comments

@zjin-lcf
Copy link

Hi

I built and ran the IS program for the class D problem size, but the verification fails. It is quite fast to run the programs with smaller problem sizes on a p100 gpu. Thank you for your updates.

@gabriellaraujo1903
Copy link
Member

Hello.

The verification routine is failing because an overflow error is occurring with class D (int type is not large enough for this class).

We will fix it as soon as possible.

Thank you for using the NPB-GPU, and thank you for reporting this bug.

@zjin-lcf
Copy link
Author

Thank you for explaining the error.

@zjin-lcf
Copy link
Author

Is there a upper bound to the value of MAX_ITERATION ? The default value is 10.

@gabriellaraujo1903
Copy link
Member

Hello.

Yes, in the practice, there is an upper bound. However, the NPB documentation does not explain which is the maximum amount of iterations supported (it may vary according to the hardware).

Our implementation followed the original NPB version, and the default value of MAX_ITERATIONS set by NASA is 10.

On my machine, I tested other values, and the benchmark worked with up to 24 iterations. With an amount of iterations larger than 24, the IS benchmark started failing in the correctness verification, even when using long int type.

@zjin-lcf
Copy link
Author

zjin-lcf commented Nov 18, 2021

Using long int type implies the class D problem. Have you updated your program to support the class D problem ?

Thanks

@gabriellaraujo1903
Copy link
Member

We haven't had time to fix this issue yet.

@gabriellaraujo1903
Copy link
Member

Hello.

We fixed the IS benchmark issue with class D.

However, class D consumes about 19 gigabytes of GPU memory. Thus, a GPU needs at least 19 gigabytes of memory to work correctly with this workload.

@gabriellaraujo1903 gabriellaraujo1903 added the bug Something isn't working label Dec 2, 2022
@zjin-lcf
Copy link
Author

zjin-lcf commented Dec 2, 2022

A memory check may be added to the CUDA program so that the test is skipped without enough memory. Thanks.

@gabriellaraujo1903
Copy link
Member

A memory check may be added to the CUDA program so that the test is skipped without enough memory. Thanks.

It is a good suggestion. We will add this feature soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants