Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The columns of hypso_df from the tool of glacier hypsometry need a sort. #19

Open
rylanlee opened this issue Dec 5, 2019 · 3 comments
Labels
question Further information is requested

Comments

@rylanlee
Copy link

rylanlee commented Dec 5, 2019

If there is a valley between glaciers distribution regions, the column of hypso_df in the example of glacier hypsometry will be out of order, which result in the yaxis of the figure in chaos.

In my opinion, add a step of sorting before the plot :

hypso_df = hypso_df.reindex(sorted(hypso_df.columns, key=int), axis=1)

@fmaussion
Copy link
Contributor

Thanks! Sorry I missed this earlier. Would you like to open a pull-request?

@rylanlee
Copy link
Author

OK. Please give me some time to know well about github.

@fmaussion
Copy link
Contributor

I'm a bit confused now. We sort the columns here:

df = df[np.append(df.columns[:3], sorted(df.columns[3:]))]

Where do you think that this line should be?

@fmaussion fmaussion added the question Further information is requested label Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants