Criteria for merging a pull request

[sjackman]

I feel that we should adopt some kind of criteria for accepting merges to the spec. Off the top of my head, I suggest

• At least three 👍 to merge
• Majority rules. Count 👍 and 👎. One vote per person. Anyone can vote.
• Wait at least three days for votes to come in, and at least one day since the most recent vote.

[sjackman]

@pmelsted

[pmelsted]

👍

[sjackman]

👍 (is my vote implied?)

[sjackman]

@ekg @jts @lh3 @noporpoise @pb-jchin Sound good?

[noporpoise]

👍

[lh3]

I usually don't like the majority rule on specification. Depending on the type of the issue, the majority don't necessarily make the best choice. It would be good for everyone to try to seek consensus. Let's see how often this doesn't work out and then decide if we have to force the majority rule.

[sjackman]

Unanimous agreement is certainly preferable. Let's see what happens. I wanted to jot down some criteria so that I'm not merging changes to the spec based on my own whim.

[jts]

Just a note that I'm on vacation this week so unlikely to contribute much. I'm with @lh3 in that we should only introduce a majority rule if we often can't reach consensus. The rules about waiting to merge and requiring endorsement from others are fine though.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.