Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Segment names conflicts in spec #120

Open
asl opened this issue Jul 14, 2023 · 0 comments
Open

Segment names conflicts in spec #120

asl opened this issue Jul 14, 2023 · 0 comments

Comments

@asl
Copy link

asl commented Jul 14, 2023

It seems that segment naming rules are different for different record types and contradict with each other.

E.g.:
For S lines we're having the following regexp: [!-)+-<>-~][!-~]*, and W lines refer to segments in walk as ([><][!-;=?-~]+)+.

As a result, it is possible to have segments with < and > in names, that would be render walks over them ambiguous to parse.

In addition to this, since segment names are allowed to have + and - in them, the parsing of path lines is context-dependent – parsing of orientation in general requires infinite lookahead, as only seeing ',' or ';' allows one to disambiguate orientation from segment name.

Given that - are pretty common used in segment names in the wild, the second issue would likely remain spec defect forever. As for the first issue, I'd suggest to refine regexps for segment names to disallow < and > in them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant