You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Type of SparsityPatternView::m_numCols and related method parameters/return values (numColumns(), resize(), etc.) is currently specified to be INDEX_TYPE, but should perhaps be COL_TYPE instead.
Currently this only results in rare clang-tidy warnings about narrowing conversions (e.g. with INDEX_TYPE = int and COL_TYPE = long long), but as soon as we try to assemble a matrix with >2B global DOFs, it becomes a real issue (at the very least, it would fail the column index check in Debug, since m_numCols would truncate in an implementation-defined way).
The text was updated successfully, but these errors were encountered:
Type of
SparsityPatternView::m_numCols
and related method parameters/return values (numColumns()
,resize()
, etc.) is currently specified to beINDEX_TYPE
, but should perhaps beCOL_TYPE
instead.Currently this only results in rare clang-tidy warnings about narrowing conversions (e.g. with
INDEX_TYPE = int
andCOL_TYPE = long long
), but as soon as we try to assemble a matrix with >2B global DOFs, it becomes a real issue (at the very least, it would fail the column index check in Debug, sincem_numCols
would truncate in an implementation-defined way).The text was updated successfully, but these errors were encountered: