Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type of SparsityPatternView::numColumns() should be COL_TYPE #258

Open
klevzoff opened this issue Apr 23, 2022 · 0 comments
Open

Type of SparsityPatternView::numColumns() should be COL_TYPE #258

klevzoff opened this issue Apr 23, 2022 · 0 comments

Comments

@klevzoff
Copy link
Contributor

Type of SparsityPatternView::m_numCols and related method parameters/return values (numColumns(), resize(), etc.) is currently specified to be INDEX_TYPE, but should perhaps be COL_TYPE instead.

Currently this only results in rare clang-tidy warnings about narrowing conversions (e.g. with INDEX_TYPE = int and COL_TYPE = long long), but as soon as we try to assemble a matrix with >2B global DOFs, it becomes a real issue (at the very least, it would fail the column index check in Debug, since m_numCols would truncate in an implementation-defined way).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant