Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect strpos() check #2

Open
primehalo opened this issue Feb 22, 2017 · 0 comments
Open

Incorrect strpos() check #2

primehalo opened this issue Feb 22, 2017 · 0 comments

Comments

@primehalo
Copy link

Lines 368-369 of e24PaymentPipe.inc.php:
$i = strpos($s, ":"); if ($i == -1) {
That check should be $i === false since strpos returns FALSE when the string is not found. Also, when the query string is built none of the parameter values are escaped with urlencode or rawurlencode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant