Skip to content
This repository has been archived by the owner on Jul 16, 2022. It is now read-only.

[Enhancement] [remindme] Limit the maximum time for a reminder #524

Open
wasdennnoch opened this issue Apr 23, 2019 · 0 comments
Open

[Enhancement] [remindme] Limit the maximum time for a reminder #524

wasdennnoch opened this issue Apr 23, 2019 · 0 comments
Assignees
Labels
priority: Substantial Issues that require substantial priority to be handled s: In Progress Issues which are WIP and should not be finished/merged. The issue is in progress target: Commands Issues that target Command files type: Enhancement Issues that enhance an existing feature or module

Comments

@wasdennnoch
Copy link
Contributor

Currently there is no upper limit on how long in the future a reminder can be, which means that it's possible to create reminders that run in a few centuries or even in Infinity years (thanks JS). While a few of those reminders probably won't be an issue in the long term people could abuse this to add masses of reminders that will practically never fire and just take up DB space and event loop queue items.

I think it would be reasonable to cap the maximum time for a reminder at something like 10 years. I don't think many people set reminders beyond one year, and anything above 100 years is either useless or a user error.

@Gilbert142 Gilbert142 added priority: Substantial Issues that require substantial priority to be handled s: In Progress Issues which are WIP and should not be finished/merged. The issue is in progress target: Commands Issues that target Command files type: Enhancement Issues that enhance an existing feature or module labels Apr 27, 2019
@Gilbert142 Gilbert142 self-assigned this Apr 27, 2019
SohamG added a commit to SohamG/GAwesomeBot that referenced this issue Sep 21, 2019
Signed-off-by: sohamg <sohamg2@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
priority: Substantial Issues that require substantial priority to be handled s: In Progress Issues which are WIP and should not be finished/merged. The issue is in progress target: Commands Issues that target Command files type: Enhancement Issues that enhance an existing feature or module
Projects
None yet
Development

No branches or pull requests

2 participants