Skip to content
This repository has been archived by the owner on Jul 16, 2022. It is now read-only.

[Bug] After modifying admin level roles, server admins can no longer access the Admin console/dashboard #491

Open
mikeinapac opened this issue Mar 24, 2019 · 5 comments
Labels
priority: Substantial Issues that require substantial priority to be handled reason: Bug Issues that are caused by a deviancy in GAB's behavior s: Awaiting Confirmation Issues which are awaiting confirmation of validity by a maintainer. The issue is in progress target: Web Issues that target GAB's Web Server

Comments

@mikeinapac
Copy link

  1. User with full server admin adds bot to server
  2. Admin modifies roles on server
  3. Server owner moves admins to new admin role (we basically just changed the name as the owner didnt have a clue how to setup Discord in the beginning)
  4. Server owner deletes old role the bot was added through
  5. Admins can no longer access dashboard
  6. Only owner can Kick bot from server
  7. Owner transfers owner to guru admin ;)
  8. All roles reset and admins assigned
  9. Guru admin can readd the bot to the server
  10. Receive error that must have level 3 server access

image

@mikeinapac mikeinapac changed the title After modifying admin level roles, server admins can no longer access the Admin console/dashboard [Bug] After modifying admin level roles, server admins can no longer access the Admin console/dashboard Mar 24, 2019
@Gilbert142 Gilbert142 added reason: Bug Issues that are caused by a deviancy in GAB's behavior target: Web Issues that target GAB's Web Server s: Awaiting Confirmation Issues which are awaiting confirmation of validity by a maintainer. The issue is in progress priority: Substantial Issues that require substantial priority to be handled labels Mar 24, 2019
@Gilbert142
Copy link
Member

Gilbert142 commented Mar 24, 2019

Hello Mike! I'd like to better understand this issue,

At step 6, was the bot kicked from the server?
At step 8, were the role/admin reassignments only in Discord, or also configured in GAB?
At step 10, does the guru admin still have Server Ownership?
When all Admin Roles removed, or is there still a Discord role that has Admin in GAB?
Is the Owner able to access the dashboard and add/remove Server Admins?

@mikeinapac
Copy link
Author

mikeinapac commented Mar 24, 2019

At step 6, was the bot kicked from the server?
Yep. We could also repeat this after step 9, however the server admins can kick the bot from the server this time. Previously when we first encountered the bug we didnt have the option to remove the bot.

At step 8, were the role/admin reassignments only in Discord, or also configured in GAB?
Server admins had no issue accessing the dashboard prior to the issue. Even though they can add the bot, they can't access the dashboard to configure GAB. Only if ownerships is transferred am I able to configure the bot

At step 10, does the guru admin still have Server Ownership?
Nope, ownership was transferred back to the original owner. If we transfer it back to me, then there are no issues accessing the dashboard.

When all Admin Roles removed, or is there still a Discord role that has Admin in GAB?
I haven't bothered to go into the config settings to resolve this so we can fix the bug.

Is the Owner able to access the dashboard and add/remove Server Admins?
Owner has no issues accessing the dashboard. I added the bot as an admin to begin with, not as owner.

@Gilbert142
Copy link
Member

Thanks!

This is likely caused by GAB remembering your config when kicked: the Server Admin list still contains the old (now deleted) roles. the Server Owner should be able to go to the Server Admins section and add the correct roles who should receive Admin status. (Let me know if this doesn't work!)

The best way to fix this issue would be to re-calculate the Server Admin list when GAB is re-added to a server. GAB normally only auto-adds Server Admins on the first time it's added to a server; this results in all roles with the Manage Server permission getting Server Admin.

@mikeinapac
Copy link
Author

I figured this was the case. We'll go through the transfer process again and I'll fix it up accordingly so that I don't nag you incessantly to fix the bug ;)

@Starbors
Copy link

Ahh

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
priority: Substantial Issues that require substantial priority to be handled reason: Bug Issues that are caused by a deviancy in GAB's behavior s: Awaiting Confirmation Issues which are awaiting confirmation of validity by a maintainer. The issue is in progress target: Web Issues that target GAB's Web Server
Projects
None yet
Development

No branches or pull requests

3 participants