Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't make classes methods private or package-private #54

Open
cdongieux opened this issue Mar 21, 2017 · 0 comments
Open

Don't make classes methods private or package-private #54

cdongieux opened this issue Mar 21, 2017 · 0 comments

Comments

@cdongieux
Copy link

Hi,

As FastScroller.setRecyclerViewPosition() behavior does not fit my needs (use LinearLayoutManager.scrollToPositionWithOffset(targetPos, 0) instead of recyclerView.scrollToPosition(targetPos)), I have to copy/paste FastScroller.java, RecyclerViewScrollListener.java and ScrollerViewProvider.java to be able to modify FastScroller.setRecyclerViewPosition() :/
So can you avoid making your methods private or package-private?

Really good work though!

Best regards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant