Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"OpenGL shader" selection box looks misleading when GDI backend is selected #288

Open
eierfrucht opened this issue Feb 12, 2024 · 2 comments

Comments

@eierfrucht
Copy link

As the title suggests: https://i.postimg.cc/5Nryxp3J/GDI.png

Steps to reproduce:

  1. Select OGL
  2. Pick a shader
  3. Switch to GDI
  4. Shader selection box is still shown and lets you pick stuff

Switching to Direct3D 9/12 replaces the selection box with a different one (DX shader apparently)

Following the same logic GDI should have no shader selection box at all; otherwise novice users are wrongly hinted that GDI somehow ought to support GLSL shaders--but none appear to work

@FunkyFr3sh
Copy link
Owner

Yeah, I'm still not sure about this one. I had the shader selection disabled first, but then people don't understand why it's disabled. Then I changed it so when you switch the shader it would automatically change the renderer to OpenGL

@eierfrucht
Copy link
Author

A greyed-out box can look confusing, but removing the box completely for unsupported renderers, wouldn't that look self-explanatory?

There also could be a plain text string like "GDI doesn't support shaders! Select a different backend for shader support." plastered in place of the shader selection box as long as GDI is selected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants