Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Memoize sp--strict-regexp-quote #603

Open
aaronjensen opened this issue May 16, 2016 · 1 comment · May be fixed by #605
Open

Memoize sp--strict-regexp-quote #603

aaronjensen opened this issue May 16, 2016 · 1 comment · May be fixed by #605
Labels
enhancement

Comments

@aaronjensen
Copy link
Contributor

One potential improvement to #595 would be to memoize sp--strict-regexp-quote. According a reverse rendered profile it's on the higher end of cpu samples. It's a pure function with a limited input set, so it's ripe for memorization. I'd be happy to offer a pull, but I don't know how you'd like to memoize it, if you'd like to pull in a package like https://github.com/skeeto/emacs-memoize or just roll your own.

+ sp--looking-back                                                269  16%
+ sp--strict-regexp-quote                                         156   9%
+ syntax-ppss                                                     151   9%
+ sp--looking-back-p                                              111   6%
  flyspell-post-command-hook                                       76   4%
+ get-frame-persp                                                  71   4%
+ sp-delete-pair                                                   55   3%
+ spaceline-ml-main                                                53   3%
+ sp--looking-at                                                   48   2%
+ sit-for                                                          39   2%
+ #<compiled 0x40ebed8b>                                           38   2%
+ intern                                                           30   1%
+ timer--time-less-p                                               30   1%
+ pl/create-or-get-cache                                           24   1%
@Fuco1
Copy link
Owner

Fuco1 commented May 16, 2016

Anything by skeeto is fine :) Go ahead, just don't forget to put it in Cask and then run cask pkg-file to regenerate the dependency tracking file.

@aaronjensen aaronjensen linked a pull request May 16, 2016 that will close this issue
Open
@Fuco1 Fuco1 modified the milestone: Backlog Jun 14, 2016
@Fuco1 Fuco1 removed this from the Backlog milestone Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
Triage
Status: To triage
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add memoization for sp--strict-regexp-quote aaronjensen/smartparens
2 participants
@aaronjensen @Fuco1