Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up org mode string pair parsing by ilmiting the parser's context to node / block #1192

Open
Fuco1 opened this issue Mar 20, 2024 · 2 comments

Comments

@Fuco1
Copy link
Owner

Fuco1 commented Mar 20, 2024

See #1031 comment from @jaccarmac

@jaccarmac
Copy link

Thanks much; Willing and able to try out the fix(es) when they're available. I probably don't have the codebase knowledge to attempt anything myself, but might end up hacking at it. In that case, any pointers are welcome.

@Fuco1
Copy link
Owner Author

Fuco1 commented Mar 20, 2024

I implemented some code that basically computes bounds of the search which are reasonable for the given buffer. In case of org mode, it makes no sense to compute anything related to pairs outside of the current headline (because that is not even syntactically valid org mode), but smartparens doesn't really know about headline / block boundaries.

During implementing this I found a couple really weird issues and went down the rabbit hole of fixing those and broke the new feature in the process :D I'll continue tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In progress
Development

No branches or pull requests

2 participants