Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving preview tab breaks preview until window reload #1

Open
adiazpallas opened this issue Jan 7, 2019 · 1 comment
Open

Moving preview tab breaks preview until window reload #1

adiazpallas opened this issue Jan 7, 2019 · 1 comment

Comments

@adiazpallas
Copy link

First of all, the extension works perfectly, I've been using it for a while now and it's always been perfect.
I just ran into this little problem which is not a big deal. If you have a preview open and, for example, want to change that tab into another group of tabs and such, it will break. The problem is that if you try to create the preview again, it won't be able to do it unless you reload the window.
I have no idea if this is a hard or easy to fix issue because I've never written a VS Code extension myself, but I thought I'd let you know.

Keep up the good work!

@FrodgE
Copy link
Owner

FrodgE commented Jun 16, 2019

Hi @adiazpallas,
Thank you for your kind words, and sorry for taking so long to reply.

I started looking at the problem you reported and I could also reproduce it, but while looking in to it issue #2 was reported and in some ways I think they are related. Although I did not find the reason behind the obscure "'MPE Preview': ModelService:..." error, I suspect it came from the now depreciated "vscode.previewHtml" command that I had been using. To resolve #2 the extension is now using the new "webview" API. It seems that this new API does not support moving virtual documents (ie the textile preview) to a different editor. There have been many requests for this feature to be developed, see #32818 and #10121, but they are still open. So by moving to this new API the problem you reported is no longer present, however the functionality you desire does not yet exist and is awaiting further development from the VS Code team.

With the above in mind, I am inclined to close this issue with the release of 1.0.2, however I'll keep it open for the moment to hear your thoughts.

Regards,
Michael.

P.S. Developing a VS Code extension isn't too bad. You could definitely put one together yourself 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants