Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the Pause at Layer Functionality for Mainsail #585

Open
Elias23 opened this issue Apr 29, 2024 · 2 comments
Open

Add the Pause at Layer Functionality for Mainsail #585

Elias23 opened this issue Apr 29, 2024 · 2 comments
Labels
enhancement New feature or request question Further information is requested

Comments

@Elias23
Copy link
Contributor

Elias23 commented Apr 29, 2024

Describe the feature or hardware support you'd like

I'd love to see pause at layer functionality from mainsail to be integrated into klippain.
https://github.com/mainsail-crew/mainsail-config#new-feature-pause-at-next-layer-and-pause-at-layer-

Additional context or information

No response

@Elias23 Elias23 added enhancement New feature or request triage This is a new issue to be sorted (automatic label) labels Apr 29, 2024
@Surion79
Copy link
Collaborator

Surion79 commented May 9, 2024

what/where exactly should that be implemented?
I only see slicer config, where we have already in klippain the set_print_stats macro call. The on layer change is slicer only and the calls for the pause layer are manual gcode calls. We could rename them, but whats the point in that?
Please explain a bit more :) Thanks!

@Surion79 Surion79 added question Further information is requested and removed triage This is a new issue to be sorted (automatic label) labels May 9, 2024
@Elias23
Copy link
Contributor Author

Elias23 commented May 10, 2024

@Surion79 As I understand it, there is a new option in mainsail to schedule pauses while printing for either the next layer change or at a certain layer. It requires, as far as I know, the slicer config you mentioned plus 2 new macros(SET_PAUSE_NEXT_LAYER and SET_PAUSE_AT_LAYER) and a redefinition of the SET_PRINT_STATS_INFO macro.
New GUI option:
image
Feature in action via overrides:
image
I assume it would be pretty straight forward to add those macros to klippain, but I might be missing something there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants