Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The install didn't work with old mainsailos #577

Open
1 task done
bofh69 opened this issue Apr 6, 2024 · 5 comments
Open
1 task done

The install didn't work with old mainsailos #577

bofh69 opened this issue Apr 6, 2024 · 5 comments
Labels
stale Issue that appear to be inactive, mark for potenial closing if stale for longer time wontfix This will not be worked on

Comments

@bofh69
Copy link

bofh69 commented Apr 6, 2024

Klippain branch

  • I confirm using the main branch

Version

v4.3.1-10-g1d9a2b5

Describe the bug and expected behavior

I ran the install script, it looked like everything was done correctly, but klipper still ran with my old config.

I have a rpi & klipper installation based on mainsailos from two years ago. It is starting klipper via systemd and a /etc/systemd/system/klippy file with these lines:

[Service]
...
Environment=KLIPPER_CONFIG=/home/pi/klipper_config/printer.cfg
ExecStart= /home/pi/klippy-env/bin/python /home/pi/klipper/klippy/klippy.py ${KLIPPER_CONFIG} -l ${KLIPPER_LOG}  -a ${KLIPPER_SOCKET}

so obviously it didn't find the new config in $HOME/printer_data/config/printer.cfg.

I had a $HOME/printer_data/config, it was a symlink to $HOME/klipper_config.

Its probably not worth updating the install script to handle this, newer mainsailos seem to use /home/pi/printer_data/printer.cfg, but maybe add something in the documentation about this? Just running ps x | grep '[/]klippy/klippy.py' showed me the path it was using.

Additional information and klippy.log

No response

@bofh69 bofh69 added bug Something isn't working triage This is a new issue to be sorted (automatic label) labels Apr 6, 2024
@EricZimmerman
Copy link
Collaborator

i would suggest reinstalling here. it will fix far more things for you than updating klippain to work with outdated directories. use this:

https://github.com/EricZimmerman/VoronTools/blob/main/OSUpgrade.md

especially since you are just starting with klippain

@bofh69
Copy link
Author

bofh69 commented Apr 6, 2024

@EricZimmerman I've already updated the os (through apt) and most other things, the old klippy service file seems to have been kept though.

@EricZimmerman
Copy link
Collaborator

thats the wrong way to do it.

start from scratch, or uninstall klipper via kiauh then reinstall to get the right paths.

@Frix-x
Copy link
Owner

Frix-x commented Apr 17, 2024

Yes this is a known issue but the thing is that it changed more than two years ago from now and there is almost no one still runnning the old paths. You can just use KIAUH to uninstall and resintall Klipper + Moonraker. This will fix your paths.

But as Eric said, there is actually more and you will probably hit another issue next that arise from Shake&Tune requirements: it needs Python >=3.9 that is not available in Debian Buster but is in Bulleyes and Bookworm.

So just upgrade your OS to a newer version and you will have everything solved at once :)

@Frix-x Frix-x added wontfix This will not be worked on and removed bug Something isn't working triage This is a new issue to be sorted (automatic label) labels Apr 17, 2024
Copy link

📌 This issue has been marked as stale because it has not had activity in the past 30 days.
To keep it open, please respond to this message or add new information. Otherwise, this will be closed in 14 days.
Thank you for your contributions!

@github-actions github-actions bot added the stale Issue that appear to be inactive, mark for potenial closing if stale for longer time label May 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Issue that appear to be inactive, mark for potenial closing if stale for longer time wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

3 participants