Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the variable adaptive_primeline to variables.cfg that can be overriden in start_print #520

Open
tsk-2222 opened this issue Mar 1, 2024 · 3 comments · May be fixed by #522
Open

Add the variable adaptive_primeline to variables.cfg that can be overriden in start_print #520

tsk-2222 opened this issue Mar 1, 2024 · 3 comments · May be fixed by #522
Labels
done Issue is done but not merged on main enhancement New feature or request stale Issue that appear to be inactive, mark for potenial closing if stale for longer time

Comments

@tsk-2222
Copy link
Contributor

tsk-2222 commented Mar 1, 2024

Describe the feature or hardware support you'd like

The latest version of klippain defaults to using adaptive primeline. Currently this can be overridden by using ADAPTIVE_PRIMELINE=0 on the start_print line.

I think it would be a good idea to add it as a variable in variables.cfg and then have the start_print macro default to using that variable.

It's an easy patch and I'lll submit a PR myself when I get back at my printer in 4 days ...unless someone beats me to it.

Additional context or information

No response
@tsk-2222 tsk-2222 added enhancement New feature or request triage This is a new issue to be sorted (automatic label) labels Mar 1, 2024
@Surion79 Surion79 linked a pull request Mar 2, 2024 that will close this issue
optional setting for adaptive primeline #522
Open
@Surion79
Copy link
Collaborator

Surion79 commented Mar 2, 2024

added a PR. please take a look

@Surion79 Surion79 added done Issue is done but not merged on main and removed triage This is a new issue to be sorted (automatic label) labels Mar 2, 2024
@Surion79 Surion79 reopened this Apr 18, 2024
@Surion79
Copy link
Collaborator

not yet completed. will be closed when merged

@github-actions GitHub Actions
Copy link

📌 This issue has been marked as stale because it has not had activity in the past 30 days.
To keep it open, please respond to this message or add new information. Otherwise, this will be closed in 14 days.
Thank you for your contributions!

@github-actions github-actions bot added the stale Issue that appear to be inactive, mark for potenial closing if stale for longer time label May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
done Issue is done but not merged on main enhancement New feature or request stale Issue that appear to be inactive, mark for potenial closing if stale for longer time
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

optional setting for adaptive primeline Frix-x/klippain
2 participants
@Surion79 @tsk-2222