Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Elements with role="dialog" or role="alertdialog" do not have accessible names. #304

Open
iceman-fx opened this issue Aug 17, 2023 · 2 comments
Open

Elements with role="dialog" or role="alertdialog" do not have accessible names. #304

iceman-fx opened this issue Aug 17, 2023 · 2 comments
Labels
in progress (5.x) currently in work

Comments

@iceman-fx
Copy link
Member

1
@IngoWinter
Copy link
Member

https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/dialog_role
https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/alertdialog_role

Normalerweise sollte es reichen, dem Element mit der role dialog eine Beschreibung über aria-label mitzugeben. Ich frage mich, ob der das div für den Hintergrund überhaupt eine role haben sollte. Aus dem Bauch raus würde ich nur dem consent_manager_wrapper die role dialog (oder sogar alertdialog) geben. Das Hintergrund div sollte eigentlich für den Screenreader unsichtbar sein.

@aeberhard aeberhard added the in progress (5.x) currently in work label Oct 11, 2023
@aeberhard
Copy link
Member

Ich werde das mal für die Version 5 berücksichtigen!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
in progress (5.x) currently in work
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@aeberhard @iceman-fx @IngoWinter