Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add KR locale #254

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add KR locale #254

wants to merge 2 commits into from

Conversation

dimitriBouteille
Copy link

Add 🇰🇷 locale

fixed #253

merlinfuchs
merlinfuchs approved these changes Apr 23, 2024
View reviewed changes
Copy link
Member

@merlinfuchs merlinfuchs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! 🚀

Could you also add the new language to the list of supported languages in docs/widget_api.md and to the changelog in docs/changelog.md? Otherwise, I will do it when the PR is merged :)

src/localization.ts
const LANG_KR: Localization = {
text_init: "초기화 중",

text_ready: "Anti-Robot 검증",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm guessing there is no good translation for Anti-Robot in Korean?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good question, for a personal need, I had translated by a person who speaks Korean, the translation is good I think 🙈

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@merlinfuchs merlinfuchs merlinfuchs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add South Korea language
2 participants
@dimitriBouteille @merlinfuchs