Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

i18n: Query strings (refactoring) #6315

Open
math-GH opened this issue Apr 17, 2024 · 0 comments
Open

i18n: Query strings (refactoring) #6315

math-GH opened this issue Apr 17, 2024 · 0 comments
Labels
good first issue help wanted I18n 🌍 Translations Not urgent 🐌 System care Everything related to the system care
Milestone
Backlog

Comments

@math-GH
Copy link
Contributor

math-GH commented Apr 17, 2024 •
edited

It is because they are used by string concatenation (which I would like to get rid of precisely because it makes validation and maintenance quite challenging). And there is another layer of property with another name for the getter, which makes it even more difficult to search:

FreshRSS/app/views/configure/queries.phtml

Line 57 in 0ffcf41

<li class="item"><?= _t('conf.query.get_' . $query->getGetType(), $query->getGetName()) ?></li>

Originally posted by @Alkarex in #6052 (comment)
@math-GH math-GH added System care Everything related to the system care I18n 🌍 Translations labels Apr 17, 2024
@Alkarex Alkarex added this to the Backlog milestone Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue help wanted I18n 🌍 Translations Not urgent 🐌 System care Everything related to the system care
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
2 participants
@Alkarex @math-GH