Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically download embeddings #13

Open
stefan-it opened this issue Feb 13, 2018 · 2 comments
Open

Automatically download embeddings #13

stefan-it opened this issue Feb 13, 2018 · 2 comments

Comments

@stefan-it
Copy link
Collaborator

Hi,

thanks creating this text classification benchmark!

I wanted to run the basic example python3 main.py --model cnn and I could see that the GloVe embeddings were not downloaded automatically.

The dataHelper.loadData(opt) never calls the Glove constructor, so the embeddings won't be downloaded. But when I change from_torchtext = False to from_torchtext = True the utils.loadData(opt) method calls the Glove constructor.

I guess calling the Glove constructor would be enough to call it before the glove_file declaration (from here)?

@wabyking
Copy link
Collaborator

Thanks for your issues. You are right.
Would you mind fixing this problem, and I will add you as a collaborators for this project.

@stefan-it
Copy link
Collaborator Author

Cool thanks :) My first attempt for solving this issue is #15.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants