{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":222826248,"defaultBranch":"main","name":"Lab-Project-FreeRTOS-FAT","ownerLogin":"FreeRTOS","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2019-11-20T01:42:33.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/54647343?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1667322694.7117372","currentOid":""},"activityList":{"items":[{"before":"d43050abd77dff663b081b675acf0c2fe7c4b0bc","after":"f834aee4d74dc796a6cf13753e1641ab5e146d98","ref":"refs/heads/main","pushedAt":"2024-04-29T02:35:50.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"moninom1","name":"Monika Singh","path":"/moninom1","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/108652024?s=80&v=4"},"commit":{"message":"Small Type and Qualifier Fixes (#67)\n\nOtherwise the condition is always true for 64-bit architectures.\r\n\r\nGCC warned me about this when compiling AARCH64 (-Wtype-limits).","shortMessageHtmlLink":"Small Type and Qualifier Fixes (#67)"}},{"before":"bfb03575759a18e54f1ae3c1dbcb464741463589","after":"d43050abd77dff663b081b675acf0c2fe7c4b0bc","ref":"refs/heads/main","pushedAt":"2024-02-27T20:03:09.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"AniruddhaKanhere","name":"Aniruddha Kanhere","path":"/AniruddhaKanhere","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/60444055?s=80&v=4"},"commit":{"message":"Change the FF_MakeNameCompliant behavior (#63)\n\n* Change the handling of invalid file-names to cause an error. Depending\r\non the entry to create (directory/file), a different error code is\r\nreturned.\r\n\r\nDescription\r\n-----------\r\nThis changes the behavior of the FF_CreateDirent function to return an\r\nerror in case of an invalid path.\r\nFilenames with the first character of 0xE5 are still modified. (Which\r\nmight have some issues. TODO)\r\n\r\nNote: Invalid directory paths and invalid file paths now result in two\r\ndifferent FreeRTOS+ return values. Is this the intended behavior or\r\nshould only one error code be used?\r\n```\r\ncase FF_ERR_FILE_INVALID_PATH:\r\n return pdFREERTOS_ERRNO_ENOTDIR; /* The path of the file was not found. */\r\ncase FF_ERR_DIR_INVALID_PATH:\r\n return pdFREERTOS_ERRNO_EINVAL; /* Could not find the directory specified by the path. */\r\n```\r\n\r\nFF_MakeNameCompliant returns a boolean and not an error-code, because\r\nthe function\r\nwould need an additional parameter to select the right error code\r\n(FF_ERR_DIR_INVALID_PATH or FF_ERR_FILE_INVALID_PATH).\r\n\r\nTest Steps\r\n-----------\r\nA invalid filepath \"test:file.txt\" resulted in setting the\r\nFF_ERR_FILE_INVALID_PATH. (Tested through breakpoint in\r\nprvFFErrorToErrno).\r\n\r\nTodo:\r\n- mkdir with invalid path\r\n- handling of names starting with 0xE5\r\n\r\nChecklist:\r\n----------\r\n\r\n\r\n- [ ] I have tested my changes. No regression in existing tests.\r\n- [ ] I have modified and/or added unit-tests to cover the code changes\r\nin this Pull Request.\r\n\r\nRelated Issue\r\n-----------\r\n\r\n\r\nBy submitting this pull request, I confirm that you can use, modify,\r\ncopy, and redistribute this contribution, under the terms of your\r\nchoice.\r\n\r\n---------\r\n\r\nCo-authored-by: Tobias Gruen ","shortMessageHtmlLink":"Change the FF_MakeNameCompliant behavior (#63)"}},{"before":"e23ce7da3f383e37f68debe322c65c475e965b3b","after":"bfb03575759a18e54f1ae3c1dbcb464741463589","ref":"refs/heads/main","pushedAt":"2024-01-30T22:35:56.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"AniruddhaKanhere","name":"Aniruddha Kanhere","path":"/AniruddhaKanhere","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/60444055?s=80&v=4"},"commit":{"message":"Enable FAT12 support in CI Build Check (#65)\n\nDescription\r\n-----------\r\nEnable FAT12 support in CI Build Check\r\n\r\nTest Steps\r\n-----------\r\nN/A\r\n\r\nChecklist:\r\n----------\r\n\r\n\r\n- [x] I have tested my changes. No regression in existing tests.\r\n- [ N/A ] I have modified and/or added unit-tests to cover the code\r\nchanges in this Pull Request.\r\n\r\nRelated Issue\r\n-----------\r\n\r\n\r\nBy submitting this pull request, I confirm that you can use, modify,\r\ncopy, and redistribute this contribution, under the terms of your\r\nchoice.","shortMessageHtmlLink":"Enable FAT12 support in CI Build Check (#65)"}},{"before":"b3d76b45e0d563cb89b6fff4b0847caa52002015","after":"e23ce7da3f383e37f68debe322c65c475e965b3b","ref":"refs/heads/main","pushedAt":"2024-01-30T22:28:02.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"AniruddhaKanhere","name":"Aniruddha Kanhere","path":"/AniruddhaKanhere","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/60444055?s=80&v=4"},"commit":{"message":"Fix usage of FF_createERR macro in prvGetFAT12Entry (#62)\n\nDescription\r\n-----------\r\n#45 introduced a compilation error about implicit `FF_CreateError`\r\nfunction when using FAT12 support. I assume it was supposed to be\r\n`FF_createERR` macro instead so I changed it.\r\n\r\nChecklist:\r\n----------\r\n\r\n\r\n- [x] I have tested my changes. No regression in existing tests.\r\n- [ ] I have modified and/or added unit-tests to cover the code changes\r\nin this Pull Request.\r\n\r\nBy submitting this pull request, I confirm that you can use, modify,\r\ncopy, and redistribute this contribution, under the terms of your\r\nchoice.","shortMessageHtmlLink":"Fix usage of FF_createERR macro in prvGetFAT12Entry (#62)"}},{"before":"bc13a8a3cbda7d9a62c3fc9186fcf20067b91836","after":"b3d76b45e0d563cb89b6fff4b0847caa52002015","ref":"refs/heads/main","pushedAt":"2024-01-30T22:20:38.000Z","pushType":"pr_merge","commitsCount":4,"pusher":{"login":"paulbartell","name":"Paul Bartell","path":"/paulbartell","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1633960?s=80&v=4"},"commit":{"message":"Remove old uncrustify.cfg","shortMessageHtmlLink":"Remove old uncrustify.cfg"}},{"before":"90281cb5ba4cd7aa77b1b49dbb13cbb4b81550be","after":"bc13a8a3cbda7d9a62c3fc9186fcf20067b91836","ref":"refs/heads/main","pushedAt":"2023-12-20T16:49:26.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"bradleysmith23","name":null,"path":"/bradleysmith23","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/74752142?s=80&v=4"},"commit":{"message":"Fix cmake configure for STM32F4XX and STM32F7XX (#59)\n\nFixed bug that prevented STM32F4XX and STM32F7XX from correctly\r\nconfigure with cmake.\r\n\r\nDescription\r\n-----------\r\nSetting `FREERTOS_PLUS_FAT_PORT` to STM32F4XX would throw fatal error at\r\nline 57 of root CMakeLists.txt since not in\r\n`FREERTOS_PLUS_FAT_PORT_LIST`.\r\nSetting `FREERTOS_PLUS_FAT_PORT` to STM32FXX as in the list of ports\r\n(notice no number before XX), would throw error since at\r\n`portable/CMakeLists.txt:38` it would NOT mach with any generator and\r\nresult in no sources for `freertos_plus_fat_port` target.\r\n\r\nTest Steps\r\n-----------\r\n\r\nset `FREERTOS_PLUS_FAT_PORT` to either STM32F4XX or STM32F7XX\r\n\r\nChecklist:\r\n----------\r\n\r\n\r\n- [ ] I have tested my changes. No regression in existing tests.\r\n- [ ] I have modified and/or added unit-tests to cover the code changes\r\nin this Pull Request.\r\n\r\nRelated Issue\r\n-----------\r\n\r\n\r\nBy submitting this pull request, I confirm that you can use, modify,\r\ncopy, and redistribute this contribution, under the terms of your\r\nchoice.","shortMessageHtmlLink":"Fix cmake configure for STM32F4XX and STM32F7XX (#59)"}},{"before":"086960fd749b638afd0985ec94e183281319c4c2","after":"90281cb5ba4cd7aa77b1b49dbb13cbb4b81550be","ref":"refs/heads/main","pushedAt":"2023-12-06T01:34:03.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"Skptak","name":"Soren Ptak","path":"/Skptak","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/24749346?s=80&v=4"},"commit":{"message":"CI-CD-Updates (#58)\n\n* Remove exec privileges from c and h files\r\n* Apply Formatting Changes\r\n* Spelling Mistake Fixes","shortMessageHtmlLink":"CI-CD-Updates (#58)"}},{"before":"25129e5221ae6ebf9d88e11f78d33c68edb254fb","after":"086960fd749b638afd0985ec94e183281319c4c2","ref":"refs/heads/main","pushedAt":"2023-11-30T17:00:01.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"Skptak","name":"Soren Ptak","path":"/Skptak","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/24749346?s=80&v=4"},"commit":{"message":"Fix dynamic FAT variant detection #55 (#56)\n\n* Fix FAT32 format check #55\r\nOnly the first two bytes were considered when reading the end-of-chain value from the FAT table. Extend to 4 bytes and relax requirement for first 3 bits.\r\nMake requirement for FAT12 more strict because all valid, non-reserved cluster bits must be set.\r\n* Fix inverted FAT12 logic\r\n* Add default heap selection to CMakeListst.txt\r\n---------\r\nCo-authored-by: Hein Tibosch \r\nCo-authored-by: Soren Ptak ","shortMessageHtmlLink":"Fix dynamic FAT variant detection #55 (#56)"}},{"before":"08d0cff40d9832f235442ab22e577ddf4204da52","after":"25129e5221ae6ebf9d88e11f78d33c68edb254fb","ref":"refs/heads/main","pushedAt":"2023-08-24T21:05:03.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"AniruddhaKanhere","name":"Aniruddha Kanhere","path":"/AniruddhaKanhere","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/60444055?s=80&v=4"},"commit":{"message":"Added API allowing user to choose settings at runtime - replacement of PR#49 (#51)\n\n* Adding in FF_SDDiskInitWithSettings optional initialization to support runtime initial mounting options.\r\n\r\n* FAT-#50: Fixing duplicate definition of st_atime, st_mtime, st_ctime for linux.\r\n\r\n* Fixing formatting with diff provided using uncrustify.\r\n\r\n---------\r\n\r\nCo-authored-by: Paul Helter ","shortMessageHtmlLink":"Added API allowing user to choose settings at runtime - replacement o…"}},{"before":"cee265469a2b6565f7900ab318b4c2a2c36d2d7b","after":"08d0cff40d9832f235442ab22e577ddf4204da52","ref":"refs/heads/main","pushedAt":"2023-05-16T19:16:58.837Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"n9wxu","name":"Joseph Julicher","path":"/n9wxu","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/750641?s=80&v=4"},"commit":{"message":"Feature/fixing clang gnu compiler warnings (#45)\n\n* Support for CMake builds. Added Linux stub port for now to allow cross\r\ncompilation.\r\n\r\n* Fixing misuse of doxygen documentation\r\n\r\n* Converting prints from %lu to %u where possible as per request in comments related to (#35)\r\n\r\n* Fixing clang compiler warnings.\r\n\r\n* Fixing build test to work regardless of configuration.\r\n\r\n* Adding in for Zynq port dependency on uncached_memory target.\r\n\r\n* Excluding build_test from all build - must request it explicitly.\r\n\r\n* Ensuring XPAR_XSDPS_0_IS_CACHE_COHERENT is 1 for this build since using\r\na modified xsdps driver that requires it.\r\n\r\n* Updating compiler warnings.\r\n\r\n* Fixing documentation, signed/unsigned conversion. Bugfix for time based code for removing failure in 2032 due to uint32_t used for time.\r\n\r\n* Fixing error creation using FF_createERR everywhere missed.\r\n\r\n* Fixing build_test in ci.yml\r\n\r\n* Uncrustify: triggered by comment.\r\n\r\n---------\r\n\r\nCo-authored-by: Nikhil Kamath <110539926+amazonKamath@users.noreply.github.com>\r\nCo-authored-by: GitHub Action ","shortMessageHtmlLink":"Feature/fixing clang gnu compiler warnings (#45)"}},{"before":"1bc8947a0c896d7bb749474d790bf6c10be72139","after":"cee265469a2b6565f7900ab318b4c2a2c36d2d7b","ref":"refs/heads/main","pushedAt":"2023-05-11T04:35:15.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"amazonKamath","name":"Nikhil Kamath","path":"/amazonKamath","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/110539926?s=80&v=4"},"commit":{"message":"Fix Uncrustify bot command (#46)\n\n* Uncrustify bot command fix (#816)\r\n\r\n* fix uncrustify run command\r\n\r\n* test uncrustify\r\n\r\n* Revert \"test uncrustify\"\r\n\r\nThis reverts commit f660ab435fa741f8767f8a2849829f02a92ecca6.\r\n\r\n* Fix uncrustify bot command - disable install prompt (#819)\r\n\r\n* fix uncrustify run command\r\n\r\n* test uncrustify\r\n\r\n* Revert \"test uncrustify\"\r\n\r\nThis reverts commit f660ab435fa741f8767f8a2849829f02a92ecca6.\r\n\r\n* removing apt-get prompt while installing git\r\n\r\n* Removing deprecated set-output command from uncrustify bot run yml (#820)\r\n\r\n* fix uncrustify run command\r\n\r\n* test uncrustify\r\n\r\n* Revert \"test uncrustify\"\r\n\r\nThis reverts commit f660ab435fa741f8767f8a2849829f02a92ecca6.\r\n\r\n* removing apt-get prompt while installing git\r\n\r\n* removing the deprecated set-output command from uncrustify bot run yml, use latest git\r\n\r\n* Update changes\r\n\r\n* Fix uncrustify\r\n\r\n---------\r\n\r\nCo-authored-by: Tony Josi ","shortMessageHtmlLink":"Fix Uncrustify bot command (#46)"}}],"hasNextPage":false,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEPIsZjQA","startCursor":null,"endCursor":null}},"title":"Activity · FreeRTOS/Lab-Project-FreeRTOS-FAT"}