Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Wrong conditions in mqtt_pkcs11_demo_helpers.c #1206

Open
KeitaKashima opened this issue Apr 11, 2024 · 1 comment
Open

[BUG] Wrong conditions in mqtt_pkcs11_demo_helpers.c #1206

KeitaKashima opened this issue Apr 11, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@KeitaKashima
Copy link

Describe the bug

In mqtt_pkcs11_demo_helpers.c, there would be typo conditions L797 and L805.

I think it should check NOT pd FAIL, likeif( xReturnStatus != pdFAIL ) but it performs if( xReturnStatus == pdFAIL ).

image

It seems that the demo is working fine.

Because this xMqttSessionEstablished flag is only used when do the MQTT Disconnect.

And when the flag is true, the device sent MQTT DISCONNECT packet.

But after that, the connection is disconnected immidiately. So, it would not affect the demo.

Target

Below is my target, but it is happened other devices.

  • Development board: CK-RX65N (Renesas RX family)
  • Instruction Set Architecture: RX65N
  • IDE and version: e2studio 2024-01
  • Toolchain and version: CC-RX V3.

Host

  • Host OS: Win10

To Reproduce

Expected behavior

Change to if( xReturnStatus != pdFAIL ) .

@KeitaKashima KeitaKashima added the bug Something isn't working label Apr 11, 2024
@xuelix
Copy link
Member

xuelix commented Apr 17, 2024

Thanks for reporting. We'll fix it.

@xuelix xuelix mentioned this issue Apr 17, 2024
2 tasks
xuelix added a commit that referenced this issue Apr 17, 2024
This is to address this issue: #1206
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants