We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Describe the bug
In mqtt_pkcs11_demo_helpers.c, there would be typo conditions L797 and L805.
I think it should check NOT pd FAIL, likeif( xReturnStatus != pdFAIL ) but it performs if( xReturnStatus == pdFAIL ).
if( xReturnStatus != pdFAIL )
if( xReturnStatus == pdFAIL )
FreeRTOS/FreeRTOS-Plus/Demo/AWS/Mqtt_Demo_Helpers/mqtt_pkcs11_demo_helpers.c
Line 797 in eb97c5d
It seems that the demo is working fine.
Because this xMqttSessionEstablished flag is only used when do the MQTT Disconnect.
xMqttSessionEstablished
And when the flag is true, the device sent MQTT DISCONNECT packet.
But after that, the connection is disconnected immidiately. So, it would not affect the demo.
Target
Below is my target, but it is happened other devices.
Host
To Reproduce
Expected behavior
Change to if( xReturnStatus != pdFAIL ) .
The text was updated successfully, but these errors were encountered:
Thanks for reporting. We'll fix it.
Sorry, something went wrong.
Fix the erroneous check (#1210)
2023ac6
This is to address this issue: #1206
No branches or pull requests
Describe the bug
In mqtt_pkcs11_demo_helpers.c, there would be typo conditions L797 and L805.
I think it should check NOT pd FAIL, like
if( xReturnStatus != pdFAIL )
but it performsif( xReturnStatus == pdFAIL )
.FreeRTOS/FreeRTOS-Plus/Demo/AWS/Mqtt_Demo_Helpers/mqtt_pkcs11_demo_helpers.c
Line 797 in eb97c5d
It seems that the demo is working fine.
Because this
xMqttSessionEstablished
flag is only used when do the MQTT Disconnect.And when the flag is true, the device sent MQTT DISCONNECT packet.
But after that, the connection is disconnected immidiately. So, it would not affect the demo.
Target
Below is my target, but it is happened other devices.
Host
To Reproduce
Expected behavior
Change to
if( xReturnStatus != pdFAIL )
.The text was updated successfully, but these errors were encountered: