New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Serbo-Croatian bugs #132
Comments
Interesting bug. @RasmusRendal can you take a look at this? Initially I got an exception from SentenceSplitter which is understandable, but even after handling it in a5bba88 it starts to crash with a different error which appears to be related to the web server.
|
Never mind, it looks like I'm dumb, and tried to initialize the splitter both in MainWindowBase and in InitSources, causing an exception there which triggered a thread issue. |
After fixing the bug, it appears that it fetches definition and audio just fine. In Forvo apparently these are treated as different languages. Is this appropriate? |
Awesome, thanks for the fix! It's working on my end in the nightly build. Regarding Forvo, if it's possible, I think it'd be ideal if the app just pulled the pronunciations for all 3 at the same time. Even better if they could show the sr, hr, bs code from the Forvo mp3s. The pronunciations are actually less different than between different Spanish accents, and there just aren't a lot of clips for these languages to begin with. Often there are words that only have audio in either Croatian or Serbian -- or the audio for one is just much better quality. It also seems like a lot of Bosnians upload clips under Croatian/Serbian, even though there's a separate listing for Bosnian. |
As I submitted in October:
#93
Serbian and Croatian words produced audio but no definitions in 0.10.2.
In 0.11.0, the problem is flipped: they now produce definitions but no audio. It doesn't matter which language, script, or audio format is used; even words that have multiple pronunciations in Forvo will not populate audio in the app.
However, Serbian/Bosnian/Croatian seem to produce further bugs within the app itself:
The text was updated successfully, but these errors were encountered: