Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

instructions required: how to create pull requests #15

Open
gregorywong opened this issue Sep 12, 2017 · 4 comments
Open

instructions required: how to create pull requests #15

gregorywong opened this issue Sep 12, 2017 · 4 comments
Assignees

Comments

@gregorywong
Copy link
Member

gregorywong commented Sep 12, 2017

As mentioned in issue #11 :

There needs to be some instructions on how to create pull requests on GitHub (specific to our org). We could possibly reference this tutorial on pull requests by GitHub guides: https://guides.github.com/activities/hello-world/

Contributor(s):

Reviewer(s):

@isaackwan
Copy link
Member

How do I become a reviewer:P?

@gregorywong
Copy link
Member Author

@isaackwan Don't think there's a way to distinguish between the writer(s) and reviewer(s), so I've updated the description to reflect that!

I may try to write the instructions if no one else takes up the task :P

@andrealaw
Copy link
Collaborator

Is it necessary to list out the reviewers/contributors explicitly? As Github automatically logs all changes for us.

Example from our wiki page:
https://github.com/FreeCodeCampHongKong/FreeCodeCampHongKong.github.io/wiki/How-to-synchronize-local-repository-with-the-latest-version-on-Github/_history

@gregorywong
Copy link
Member Author

@andrealaw This is just for this task specifically (more for my own reference). Since I might not be able to work on it right away, it'll be good to have a summary of our discussion to refer to later, instead of having to go through the conversation log each time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants