Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement pagination on transfer job listing #402

Merged

Conversation

nathanthorpe
Copy link
Member

@nathanthorpe nathanthorpe commented Jun 2, 2022

Resolves #385. This PR adds pagination to the transfers pane at the top.

  • Pagination buttons do not show if there is only one page
  • When there are between 2 - 5 pages it shows a simple selector.
    image
  • When there are more than 5 pages it shows a selector with first/last/ellipses/etc depending on what page you are on.
    image
    image

Note that the copy-jobs list endpoint sends back a different model to include page information.

It includes the option to specify the page size in the API but that is not exposed in the UI.

@dtenenba dtenenba changed the base branch from master to test-pagination-pr September 11, 2023 21:09
@dtenenba dtenenba merged commit cef2973 into FredHutch:test-pagination-pr Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

limit of 50 jobs in transfers pane is a problem....
2 participants