Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does this project need a specific version of rouge? #11

Open
manhongxiang opened this issue Apr 22, 2020 · 2 comments
Open

Does this project need a specific version of rouge? #11

manhongxiang opened this issue Apr 22, 2020 · 2 comments

Comments

@manhongxiang
Copy link

I use "pip install rouge" to install , and it automatically installs version 1.0.0

I got errors when running main.py
1.rouge.Rouge(metrics=['rouge-n', 'rouge-l'], max_n=2)
max_n is an unexpected param
rouge-n is not found

Then I delete them and run it again.
2.rouge_scores = self.rouge_evaluator.get_scores(rouge_pred, rouge_ref)
rouge_ref is an invalid parameter. The API get_scores takes rouge_ref as a list of str, but here rouge_ref is a list of list of str

Then I modify rouge_ref, and pass to get_scores a correct param
3.metrics_dict["rouge_1"] = rouge_scores["rouge-1"]["r"]
rouge_scores is a list, not a dict.

So, am I using the correct rouge?

@nathias2004
Copy link

#5 (comment)

@manhongxiang
Copy link
Author

#5 (comment)

Thank you. It works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants