Reduce function complexity in MapRenderer #1045

Framstag · 2021-04-02T09:23:32Z

MapRenderer contains "tricky" code. At the same time CLion hints at "too high" complexity for some methods. We should reduce the complexity of the methods by moving code parts out of the rather long methods. At the same time we should give methods and variables better names to make the code better to understand.

* Extract OffsetRel code * Enhanced Way API * Cleanup of MapPainter::CalculatePaths method

Issue #1045 - further cleanup

Framstag · 2023-04-08T15:40:08Z

This might also help for finalizing issue #1220.

- Made more use of Vertex2D - Simplify APIs by using Vertex2D instead of x,y - Added Way.IsValid() - Reduce Sonar warnings

- Fix iOSX build

- Regenerated test database

- Moved the painter statistics code to separate files to reduce code size and build time of MapPainter - Tuned clang-tidy configuration

- Move MapPainterBatch to separate header. - Renamed MapPainterMatch to BatchMapPainter (and adapt Qt code) - Added BoundingBoxToPixel returning ScreenBox - Made use for it - Enhanced ScreenBox - Added tests for ScreenBox

Issue #1045 - Cleanup of MapPainter

- Further deprecations, cleanups and transformation of APIs to Vertex2D

Issue #1045 - Cleanup of MapPainter

- Rmeove deprecated methods (Projection, Pixel, Transformation) - Add test for MercatorProjection - Updated Catch2 to current V2 version

- Remove more unused methods

- MOve TileProjection and MercatorProjection to their own headers - Move Projections to projection package/directory - Adapt includes - Fixed builds

- Added simple Earth object to centralize some constants - Changed enum type of LaneTurn - Centralized gradtorad constant

- Fix build error

- Fix warning because of implicit size_t -> double cast.

- Fix Sonar warnings

- Fix GitHub Actions warning

- Transformed lat/lon to center

- Use GeoBox as Boundingbox for Projection.

- Added operators and Constructors for BatchTransformer

- Mark BatchTransformer as final

Issue #1045 - Update projection

- Made more use of Vertex2D - Simplify APIs by using Vertex2D instead of x,y - Added Way.IsValid() - Reduce Sonar warnings

- Fix iOSX build

- Regenerated test database

- Moved the painter statistics code to separate files to reduce code size and build time of MapPainter - Tuned clang-tidy configuration

- Move MapPainterBatch to separate header. - Renamed MapPainterMatch to BatchMapPainter (and adapt Qt code) - Added BoundingBoxToPixel returning ScreenBox - Made use for it - Enhanced ScreenBox - Added tests for ScreenBox

- Further deprecations, cleanups and transformation of APIs to Vertex2D

- Rmeove deprecated methods (Projection, Pixel, Transformation) - Add test for MercatorProjection - Updated Catch2 to current V2 version

- Remove more unused methods

- MOve TileProjection and MercatorProjection to their own headers - Move Projections to projection package/directory - Adapt includes - Fixed builds

- Added simple Earth object to centralize some constants - Changed enum type of LaneTurn - Centralized gradtorad constant

- Fix build error

- Fix warning because of implicit size_t -> double cast.

- Fix Sonar warnings

- Fix GitHub Actions warning

- Transformed lat/lon to center

- Use GeoBox as Boundingbox for Projection.

- Added operators and Constructors for BatchTransformer

- Mark BatchTransformer as final

Framstag added feature For issues and pull request that request or implement a new feature refactoring For pull requests that contain refactorings labels Apr 2, 2021

Framstag mentioned this issue Apr 2, 2021

Some cleanup of the render and transformation code #1043

Merged

Framstag pushed a commit that referenced this issue Oct 15, 2021

Issue #1045:

9bfd01e

* Extract OffsetRel code * Enhanced Way API * Cleanup of MapPainter::CalculatePaths method

Framstag added a commit that referenced this issue Oct 15, 2021

Merge pull request #1138 from Framstag/issue_1045_4

d03bf24

Issue #1045 - further cleanup

Framstag added a commit that referenced this issue Apr 9, 2023

Issue #1045 - Cleanup of MapPainter

1c2824e

- Made more use of Vertex2D - Simplify APIs by using Vertex2D instead of x,y - Added Way.IsValid() - Reduce Sonar warnings

Framstag added a commit that referenced this issue Apr 9, 2023

Issue #1045 - Cleanup of MapPainter

fcd36a1

- Fix iOSX build

Framstag added a commit that referenced this issue Apr 9, 2023

Issue #1045 - Cleanup of MapPainter

bc9f7ba

- Regenerated test database

Framstag added a commit that referenced this issue Apr 9, 2023

Issue #1045 - Cleanup of MapPainter

89279c0

- Moved the painter statistics code to separate files to reduce code size and build time of MapPainter - Tuned clang-tidy configuration

Framstag added a commit that referenced this issue Apr 10, 2023

Merge pull request #1412 from Framstag/painter_and_co_cleanup

b56d104

Issue #1045 - Cleanup of MapPainter

Framstag added a commit that referenced this issue Apr 10, 2023

Issue #1045 - Cleanup of MapPainter

6564a62

- Further deprecations, cleanups and transformation of APIs to Vertex2D

Framstag added a commit that referenced this issue Apr 10, 2023

Merge pull request #1413 from Framstag/painter_and_co_cleanup

93cfe02

Issue #1045 - Cleanup of MapPainter

Framstag added a commit that referenced this issue Apr 15, 2023

Issue #1045 - Update projection

e83e488

- Rmeove deprecated methods (Projection, Pixel, Transformation) - Add test for MercatorProjection - Updated Catch2 to current V2 version

Framstag added a commit that referenced this issue Apr 15, 2023

Issue #1045 - Update projection

b2976f9

- Remove more unused methods

Framstag added a commit that referenced this issue Apr 15, 2023

Issue #1045 - Update projection

79e0436

- MOve TileProjection and MercatorProjection to their own headers - Move Projections to projection package/directory - Adapt includes - Fixed builds

Framstag added a commit that referenced this issue Apr 16, 2023

Issue #1045 - Update projection

aeaf803

- Added simple Earth object to centralize some constants - Changed enum type of LaneTurn - Centralized gradtorad constant

Framstag added a commit that referenced this issue Apr 16, 2023

Issue #1045 - Update projection

555235a

- Fix build error

Framstag added a commit that referenced this issue Apr 16, 2023

Issue #1045 - Update projection

e099ca3

- Fix build error

Framstag added a commit that referenced this issue Apr 16, 2023

Issue #1045 - Update projection

fba1135

- Fix build error

Framstag added a commit that referenced this issue Apr 16, 2023

Issue #1045 - Update projection

52e5940

- Fix build error

Framstag added a commit that referenced this issue Apr 16, 2023

Issue #1045 - Update projection

d5541fc

- Fix warning because of implicit size_t -> double cast.

Framstag added a commit that referenced this issue Apr 16, 2023

Issue #1045 - Update projection

fdfdb61

- Fix Sonar warnings

Framstag added a commit that referenced this issue Apr 16, 2023

Issue #1045 - Update projection

de5de7f

- Fix GitHub Actions warning

Framstag added a commit that referenced this issue Apr 16, 2023

Issue #1045 - Update projection

87c4547

- Transformed lat/lon to center

Framstag added a commit that referenced this issue Apr 16, 2023

Issue #1045 - Update projection

8b72676

- Use GeoBox as Boundingbox for Projection.

Framstag added a commit that referenced this issue Apr 16, 2023

Issue #1045 - Update projection

7fcbcfd

- Added operators and Constructors for BatchTransformer

Framstag added a commit that referenced this issue Apr 16, 2023

Issue #1045 - Update projection

c0a6b38

- Mark BatchTransformer as final

Framstag added a commit that referenced this issue Apr 16, 2023

Merge pull request #1417 from Framstag/projection_updates

d5a1bdc

Issue #1045 - Update projection

DerKleinePunk pushed a commit to DerKleinePunk/libosmscout that referenced this issue Jul 16, 2023

Issue Framstag#1045 - Cleanup of MapPainter

95b09be

- Made more use of Vertex2D - Simplify APIs by using Vertex2D instead of x,y - Added Way.IsValid() - Reduce Sonar warnings

DerKleinePunk pushed a commit to DerKleinePunk/libosmscout that referenced this issue Jul 16, 2023

Issue Framstag#1045 - Cleanup of MapPainter

41e1fbd

- Fix iOSX build

DerKleinePunk pushed a commit to DerKleinePunk/libosmscout that referenced this issue Jul 16, 2023

Issue Framstag#1045 - Cleanup of MapPainter

60cabe7

- Regenerated test database

DerKleinePunk pushed a commit to DerKleinePunk/libosmscout that referenced this issue Jul 16, 2023

Issue Framstag#1045 - Cleanup of MapPainter

1385669

- Moved the painter statistics code to separate files to reduce code size and build time of MapPainter - Tuned clang-tidy configuration

DerKleinePunk pushed a commit to DerKleinePunk/libosmscout that referenced this issue Jul 16, 2023

Issue Framstag#1045 - Cleanup of MapPainter

ebed0f3

- Further deprecations, cleanups and transformation of APIs to Vertex2D

DerKleinePunk pushed a commit to DerKleinePunk/libosmscout that referenced this issue Jul 16, 2023

Issue Framstag#1045 - Update projection

9cd0e60

- Rmeove deprecated methods (Projection, Pixel, Transformation) - Add test for MercatorProjection - Updated Catch2 to current V2 version

DerKleinePunk pushed a commit to DerKleinePunk/libosmscout that referenced this issue Jul 16, 2023

Issue Framstag#1045 - Update projection

a7538fd

- Remove more unused methods

DerKleinePunk pushed a commit to DerKleinePunk/libosmscout that referenced this issue Jul 16, 2023

Issue Framstag#1045 - Update projection

319b378

- Added simple Earth object to centralize some constants - Changed enum type of LaneTurn - Centralized gradtorad constant

DerKleinePunk pushed a commit to DerKleinePunk/libosmscout that referenced this issue Jul 16, 2023

Issue Framstag#1045 - Update projection

aaf65c6

- Fix build error

DerKleinePunk pushed a commit to DerKleinePunk/libosmscout that referenced this issue Jul 16, 2023

Issue Framstag#1045 - Update projection

9156228

- Fix build error

DerKleinePunk pushed a commit to DerKleinePunk/libosmscout that referenced this issue Jul 16, 2023

Issue Framstag#1045 - Update projection

4932656

- Fix build error

DerKleinePunk pushed a commit to DerKleinePunk/libosmscout that referenced this issue Jul 16, 2023

Issue Framstag#1045 - Update projection

749f8f7

- Fix build error

DerKleinePunk pushed a commit to DerKleinePunk/libosmscout that referenced this issue Jul 16, 2023

Issue Framstag#1045 - Update projection

5f16839

- Fix warning because of implicit size_t -> double cast.

DerKleinePunk pushed a commit to DerKleinePunk/libosmscout that referenced this issue Jul 16, 2023

Issue Framstag#1045 - Update projection

9610392

- Fix Sonar warnings

DerKleinePunk pushed a commit to DerKleinePunk/libosmscout that referenced this issue Jul 16, 2023

Issue Framstag#1045 - Update projection

e5760ea

- Fix GitHub Actions warning

DerKleinePunk pushed a commit to DerKleinePunk/libosmscout that referenced this issue Jul 16, 2023

Issue Framstag#1045 - Update projection

553b506

- Transformed lat/lon to center

DerKleinePunk pushed a commit to DerKleinePunk/libosmscout that referenced this issue Jul 16, 2023

Issue Framstag#1045 - Update projection

fc421c3

- Use GeoBox as Boundingbox for Projection.

DerKleinePunk pushed a commit to DerKleinePunk/libosmscout that referenced this issue Jul 16, 2023

Issue Framstag#1045 - Update projection

b26cdb1

- Added operators and Constructors for BatchTransformer

DerKleinePunk pushed a commit to DerKleinePunk/libosmscout that referenced this issue Jul 16, 2023

Issue Framstag#1045 - Update projection

189bfe2

- Mark BatchTransformer as final

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Reduce function complexity in MapRenderer #1045

Reduce function complexity in MapRenderer #1045

Framstag commented Apr 2, 2021

Framstag commented Apr 8, 2023

Reduce function complexity in MapRenderer #1045

Reduce function complexity in MapRenderer #1045

Comments

Framstag commented Apr 2, 2021

Framstag commented Apr 8, 2023